8365983: Tests should throw SkippedException when SCTP not supported #26903
+124
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@sendaoYan The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
fandreuz
reviewed
Aug 22, 2025
| @@ -341,6 +338,10 @@ class UnsupportedSocketAddress extends SocketAddress { } | |||
| void check(boolean cond, String failMessage) {if (cond) pass(); else fail(failMessage);} | |||
| void debug(String message) {if(debug) { System.out.println(message); } } | |||
| public static void main(String[] args) throws Throwable { | |||
| if (!Util.isSCTPSupported()) { | |||
| throw new jtreg.SkippedException("SCTP protocol is not supported"); | |||
There was a problem hiding this comment.
Why do you need to qualify the name with jtreg.?
Webrevs
|
ExE-Boss
reviewed
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, take test/jdk/com/sun/nio/sctp/SctpMultiChannel/Branch.java as example. When Util.isSCTPSupported() return false, then test print a warning and the exit.
I think it's better to throw jtreg.SkippedException rather than only print a warning and then report test passed.
Change has been verified locally, test-fix only, almost no risk.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26903/head:pull/26903$ git checkout pull/26903Update a local copy of the PR:
$ git checkout pull/26903$ git pull https://git.openjdk.org/jdk.git pull/26903/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26903View PR using the GUI difftool:
$ git pr show -t 26903Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26903.diff
Using Webrev
Link to Webrev Comment