Skip to content

8366028: MethodType::fromMethodDescriptorString should not throw UnsupportedOperationException for invalid descriptors #26909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

liach
Copy link
Member

@liach liach commented Aug 23, 2025

A previous cleanup #14642 accidentally omitted the fact that an Array.newInstance call in BytecodeDescriptor::parseSig is intended to propagate IllegalArgumentException to MethodType::fromMethodDescriptorString. This bug is discovered in a recent cleanup for BytecodeDescriptor in #24978.

Instead of restoring the original newInstance call, this patch catches the UnsupportedOperationException thrown by Class::arrayType to because the cause IAE thrown by newInstance has no message at all. The existing reporting system in BytecodeDescriptor::parseMethod includes the whole malformed descriptor string in the error message, which can be triggered by returning null in parseSig.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8366028: MethodType::fromMethodDescriptorString should not throw UnsupportedOperationException for invalid descriptors (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26909/head:pull/26909
$ git checkout pull/26909

Update a local copy of the PR:
$ git checkout pull/26909
$ git pull https://git.openjdk.org/jdk.git pull/26909/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26909

View PR using the GUI difftool:
$ git pr show -t 26909

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26909.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 23, 2025

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 23, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Aug 23, 2025

@liach The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review labels Aug 23, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 23, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant