8366028: MethodType::fromMethodDescriptorString should not throw UnsupportedOperationException for invalid descriptors #26909
+31
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous cleanup #14642 accidentally omitted the fact that an
Array.newInstance
call inBytecodeDescriptor::parseSig
is intended to propagateIllegalArgumentException
toMethodType::fromMethodDescriptorString
. This bug is discovered in a recent cleanup forBytecodeDescriptor
in #24978.Instead of restoring the original
newInstance
call, this patch catches theUnsupportedOperationException
thrown byClass::arrayType
to because the cause IAE thrown bynewInstance
has no message at all. The existing reporting system inBytecodeDescriptor::parseMethod
includes the whole malformed descriptor string in the error message, which can be triggered by returningnull
inparseSig
.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26909/head:pull/26909
$ git checkout pull/26909
Update a local copy of the PR:
$ git checkout pull/26909
$ git pull https://git.openjdk.org/jdk.git pull/26909/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26909
View PR using the GUI difftool:
$ git pr show -t 26909
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26909.diff
Using Webrev
Link to Webrev Comment