Skip to content

Update NanoTDF spec to handle ECSDA signature with different r and s value sizes #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update NanoTDF spec to handle ECSDA signature with different r and s value sizes #17

wants to merge 1 commit into from

Conversation

sujankota
Copy link

@sujankota sujankota commented Jul 13, 2023 •
edited
Loading

Proposed Changes

Checklist

  • A clear description of the change has been included in this PR.
  • A clear description of whether this change is a Major, Minor, Patch or cosmetic change as per the Versioning Guidelines has been included in this PR.
  • All schema validation tests have been updated appropriately and are passing.
  • MAJOR/MINOR VERSION CHANGES ONLY: This PR should be made in branches prefixed with draft-<change>
  • MAJOR/MINOR VERSION CHANGES ONLY: A link to a reference implementation (PR or set of PRs) of the change has been included in this PR.
  • MAJOR/MINOR VERSION CHANGES ONLY: A writeup has been included discussing the motivation and impact of this change.
  • MAJOR/MINOR VERSION CHANGES ONLY: The minimum wait time has elapsed.
  • DRAFT MERGE ONLY: Draft Semver has been updated in the VERSION file (optional)
  • DRAFT MERGE ONLY: Tagged this branch with new semver version and an annotation describing the change (ex: git tag -s 4.1.0 -m "Spec version 4.1.0 - did a thing")
  • DRAFT MERGE ONLY: Version numbers have been updated as per the Versioning Guidelines.
  • This change otherwise adheres to the project Contribution Guidelines.

@sujankota sujankota requested a review from a team as a code owner July 13, 2023 19:46
@sujankota sujankota requested a review from biscoe916 July 20, 2023 18:12
@mkleene mkleene mentioned this pull request Aug 20, 2025
Merged
mkleene added a commit to opentdf/java-sdk that referenced this pull request Aug 21, 2025
@mkleene @gemini-code-assist
fix(sdk): parse the component sizes (#286)
3b1bb69 
we serialize the components `r` and `s` of an ECDSA signature as:
```
| length of r in bytes (1 byte) | r | length of s in bytes (1 byte) | s |
```
The change to the spec is implemented
[here](opentdf/spec#17) and hasn't been merged
yet

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biscoe916 biscoe916 Awaiting requested review from biscoe916

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sujankota