ODSC-60854: pass model params via kwargs, ruff formatting #922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeloop
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas and
qiuosier
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
prasankh
previously approved these changes
Aug 5, 2024
ahosler
previously approved these changes
Aug 5, 2024
| 12: [ | ||
| RollingMean( | ||
| window_size=model_kwargs.get("RollingMean", 24), | ||
| min_samples=1, |
There was a problem hiding this comment.
min_samples set to 1 is a better default compared to the default None which sets it equal to the window_size.
ahosler
approved these changes
Aug 13, 2024
prasankh
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ODSC-60854: pass model params via kwargs, ruff formatting