-
Notifications
You must be signed in to change notification settings - Fork 108
feat: Improvements to selectize plugin defaults/updates #2064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
cpsievert
wants to merge
21
commits into
main
Choose a base branch
from
feat/selectize-options
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+206
−143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64694e8
to
b2e5799
Compare
b2e5799
to
e350db0
Compare
b86a561
to
a720e43
Compare
cpsievert
commented
Aug 26, 2025
elnelson575
reviewed
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pairs with rstudio/shiny#4276 (and, less importantly, rstudio/shiny#4275) to do the following:
Fixes Inconsistent behavior when specifying options in update_selectize() #2055
update_selectize(options=...)
now preserves it's default plugins (i.e.,remove_button
/clear_button
) correctly (in both theserver=True/False
cases).Adds a
remove_button
parameter toupdate_selectize()
so that the user can easily remove/add if that behavior should change from some reason.Adds support for a
input_selectize(remove_button="both")
value, which can be useful withmultiple=True
TODO
clear_button
fix: improve styling of 'clear_button' selectize plugin rstudio/shiny#4277shinyRemoveButton
selectize.js option (for py-shiny) rstudio/shiny#4276 and fix: add CSS workaround to hide all but the first selectize remove button rstudio/shiny#4275))htmlDependencies.R
to point atmain