Skip to content

i18n(be): Update Settings and SubmitSaveAllSettings Keys #3601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2025
Merged

i18n(be): Update Settings and SubmitSaveAllSettings Keys #3601

merged 2 commits into from
Aug 26, 2025

Conversation

adi-ray
Copy link
Contributor

@adi-ray adi-ray commented Aug 23, 2025

Progress Towards #3510

Changes:

  1. Replaced SubmitSaveAllSettings with SaveAccountDetails in Bengali locale file.
  2. Updated Settings in the AccountView section of the Bengali locale file.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@adi-ray
Copy link
Contributor Author

adi-ray commented Aug 23, 2025

Tip

Shouldn't the locale code be bn for Bengali instead of be?

yugalkaushik
yugalkaushik approved these changes Aug 24, 2025
View reviewed changes
Copy link
Contributor

@yugalkaushik yugalkaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raclim
Copy link
Collaborator

raclim commented Aug 26, 2025

Shouldn't the locale code be bn for Bengali instead of be?

Great catch @adi-ray! Feel free to open a separate issue/PR for it!

raclim
raclim approved these changes Aug 26, 2025
View reviewed changes
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your work on this @adi-ray and for your review @yugalkaushik!

@raclim raclim merged commit fc5f6ed into processing:develop Aug 26, 2025
1 check passed
@adi-ray adi-ray mentioned this pull request Aug 26, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raclim raclim raclim approved these changes

+1 more reviewer

@yugalkaushik yugalkaushik yugalkaushik approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adi-ray @raclim @yugalkaushik