CLI attach command --help appears to be outdated #2791
Conversation
![devloai[bot]](https://avatars.githubusercontent.com/in/886113?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary:
This PR updates the CLI attach command help text to remove outdated options and align with current implementation:
• Removes obsolete "latest" option that is no longer supported
• Removes deprecated "dynamosafe" option
• Replaces with "DEFAULT" option for using default engine
Review Summary:
The PR correctly identifies and removes outdated help documentation that referenced unsupported options. However, there's a critical case sensitivity issue where the help text shows "DEFAULT" but the actual usage patterns and code implementation expect "default" (lowercase). This inconsistency would cause user confusion when the command fails with the documented uppercase version.
Follow-up suggestions:
@devloai fix the identified case sensitivity issue
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CLI attach command help documentation to reflect the current supported options. The changes remove outdated engine version options and replace them with the currently supported default option.
- Replaces "latest" engine option with "DEFAULT" in help text
- Removes the unsupported "dynamosafe" engine option
|
It looks good, thanks @frank-e-loftus |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25246+0855-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25248+0948-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25251+0758-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25251+0805-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25251+0824-wip |
|
📦 New work-in-progress (wip) builds are available for 5.2.0.25252+1659-wip |
CLI attach command --help appears to be outdated
The --help for the attach command gives the option "latest" which does not appear to be supported anymore:
Unless I'm misunderstanding, I believe it should instead list "DEFAULT".
Same for the "dynamosafe" option. It appears to be unsupported: