Skip to content

Add Emscripten libmpdec build step #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add Emscripten libmpdec build step #615

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db4c824
Add Emscripten libmpdec build step
hoodmane Jul 22, 2025
ca15617
Update name
hoodmane Jul 22, 2025
a27172f
Make new step conditional on not 3.14
hoodmane Jul 24, 2025
ccad77b
Update master/custom/factories.py
hoodmane Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions master/custom/factories.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1339,7 +1339,7 @@ class EmscriptenBuild(BaseBuild):
buildersuffix = ".emscripten"
factory_tags = ["emscripten"]

def setup(self, **kwargs):
def setup(self, *, branch, **kwargs):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def setup(self, *, branch, **kwargs):
def setup(self, **kwargs):

compile_environ = {
"PATH": os.pathsep.join([
"/home/emscripten/emsdk",
Expand All @@ -1365,10 +1365,21 @@ def setup(self, **kwargs):
env=compile_environ,
),
Compile(
name="Compile host libFFI",
name="Compile host libffi",
command=["python3", "Tools/wasm/emscripten", "make-libffi"],
env=compile_environ,
),
])
if branch != '3.14':
# Can enable on 3.14 if/when python/cpython#161845 is merged
self.addStep(
Compile(
name="Compile host libmpdec",
command=["python3", "Tools/wasm/emscripten", "make-mpdec"],
env=compile_environ,
)
)
self.addSteps([
Configure(
name="Configure host Python",
command=["python3", "Tools/wasm/emscripten", "configure-host"],
Expand Down