gh-133125: Clarify ZipInfo.date_time attribute documentation #136082
Conversation
…f timestamp and limitations
|
This is how it looks like |
There was a problem hiding this comment.
@KentaroJay thanks for the PR! Would you be interested in adding information about the way CPython interprets the timezone of the datetime (i.e. the time is interpreted as the local timezone). This was brought up in #123059.
I can do that in a follow up if you'd prefer to keep this focused on just covering the source of the timestamp information.
|
@emmatyping |
Co-authored-by: Emma Smith <emma@emmatyping.dev>
|
Hi @emmatyping ! |
Co-authored-by: Emma Smith <emma@emmatyping.dev>
emmatyping
added
needs backport to 3.13
|
Thanks @KentaroJay for the PR, and @emmatyping for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @KentaroJay for the PR, and @emmatyping for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
…ythonGH-136082) Specifically, clarify that ZipInfo.date_time pulls the datetime information from the central directory, and that times are interpreted as local time. (cherry picked from commit 282e885) Co-authored-by: Kentaro Jay Takahashi <64148935+KentaroJay@users.noreply.github.com> Co-authored-by: Emma Smith <emma@emmatyping.dev>
…ythonGH-136082) Specifically, clarify that ZipInfo.date_time pulls the datetime information from the central directory, and that times are interpreted as local time. (cherry picked from commit 282e885) Co-authored-by: Kentaro Jay Takahashi <64148935+KentaroJay@users.noreply.github.com> Co-authored-by: Emma Smith <emma@emmatyping.dev>
|
GH-138076 is a backport of this pull request to the 3.13 branch. |
|
GH-138077 is a backport of this pull request to the 3.14 branch. |
…H-136082) (#138076) gh-133125: Clarify ZipInfo.date_time attribute documentation (GH-136082) Specifically, clarify that ZipInfo.date_time pulls the datetime information from the central directory, and that times are interpreted as local time. (cherry picked from commit 282e885) Co-authored-by: Kentaro Jay Takahashi <64148935+KentaroJay@users.noreply.github.com> Co-authored-by: Emma Smith <emma@emmatyping.dev>
…ython#136082) Specifically, clarify that ZipInfo.date_time pulls the datetime information from the central directory, and that times are interpreted as local time. Co-authored-by: Emma Smith <emma@emmatyping.dev>
zipfile: docs should document whatZipInfo.date_timeactually is #133125📚 Documentation preview 📚: https://cpython-previews--136082.org.readthedocs.build/