Skip to content

gh-136134: imaplib: fix CRAM-MD5 on FIPS-only environments #136615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 22, 2025
Merged

gh-136134: imaplib: fix CRAM-MD5 on FIPS-only environments #136615

merged 3 commits into from
Aug 22, 2025
+45 −33

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Jul 13, 2025 •
edited by bedevere-app bot
Loading

@picnixz picnixz requested a review from a team as a code owner July 13, 2025 09:23
@picnixz picnixz changed the title gh136134: imaplib: fix CRAM-MD5 on FIPS-only environments gh-136134: imaplib: fix CRAM-MD5 on FIPS-only environments Jul 13, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jul 13, 2025
Open
@picnixz picnixz force-pushed the fix/imaplib/cram-md5-136134 branch 3 times, most recently from 3574c99 to 8af7f56 Compare July 13, 2025 10:26
@picnixz picnixz force-pushed the fix/imaplib/cram-md5-136134 branch from 8af7f56 to e218344 Compare July 13, 2025 10:34
@picnixz picnixz marked this pull request as draft July 29, 2025 12:19
@picnixz picnixz marked this pull request as ready for review July 29, 2025 12:20
@picnixz
Copy link
Member Author

picnixz commented Aug 22, 2025

!buildbot FIPS only

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 40742ce 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136615%2Fmerge

The command will test the builders whose names match following regular expression: FIPS only

The builders matched are:

  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR

@picnixz picnixz merged commit 4519b8a into python:main Aug 22, 2025
45 checks passed
@picnixz picnixz deleted the fix/imaplib/cram-md5-136134 branch August 22, 2025 10:08
@picnixz picnixz added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Aug 22, 2025
@miss-islington-app
Copy link

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @picnixz, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4519b8acb5a65df2af69e60b0d8c0a5df5bfb087 3.13

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2025
@picnixz @miss-islington
pythongh-136134: imaplib: fix CRAM-MD5 on FIPS-only environments (pyt…
99a8d2e 
…honGH-136615)

(cherry picked from commit 4519b8a)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 22, 2025

GH-138051 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Aug 22, 2025
@picnixz
Copy link
Member Author

picnixz commented Aug 22, 2025

Oh great, it's not possible to test it easily because I don't have the helpers for blocking algorithms.

@picnixz picnixz removed the needs backport to 3.13 bugs and security fixes label Aug 22, 2025
picnixz added a commit to picnixz/cpython that referenced this pull request Aug 22, 2025
@picnixz
[3.14] pythongh-136134: imaplib: fix CRAM-MD5 on FIPS-only environmen…
14cb223 
…ts (pythonGH-136615)

(cherry picked from commit 4519b8a)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz added a commit to picnixz/cpython that referenced this pull request Aug 22, 2025
@picnixz
[3.14] pythongh-136134: imaplib: fix CRAM-MD5 on FIPS-only environmen…
ba362ef 
…ts (pythonGH-136615)

(cherry picked from commit 4519b8a)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz added a commit to picnixz/cpython that referenced this pull request Aug 22, 2025
@picnixz
[3.14] pythongh-136134: imaplib: fix CRAM-MD5 on FIPS-only environmen…
6450d07 
…ts (pythonGH-136615)

(cherry picked from commit 4519b8a)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 22, 2025

GH-138054 is a backport of this pull request to the 3.14 branch.

picnixz added a commit to picnixz/cpython that referenced this pull request Aug 22, 2025
@picnixz
[3.13] pythongh-136134: imaplib: fix CRAM-MD5 on FIPS-only environmen…
63a0e8c 
…ts (pythonGH-136615)

(cherry picked from commit 4519b8a)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 22, 2025

GH-138055 is a backport of this pull request to the 3.13 branch.

@picnixz
Copy link
Member Author

picnixz commented Aug 22, 2025

I decided to backport this because people don't expect to actually catch a ValueError but would rather expect to catch an IMAP error. In both cases, there is no fallback so it's not an issue but I think it's better to raise the correct exception here.

picnixz added a commit that referenced this pull request Aug 23, 2025
@picnixz
[3.13] gh-136134: imaplib: fix CRAM-MD5 on FIPS-only environments (GH…
3afc263 
…-136615) (#138055)

(cherry picked from commit 4519b8a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@picnixz @bedevere-bot