Skip to content

gh-110936: Improve string literal definition in Lexical Analysis #138063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Aug 22, 2025

@AA-Turner
Copy link
Member

cc @encukou, we've just reworded this section.

Perhaps this PR should be deferred in favour of the eventual goal of automatically generating the grammar snippets in the documentation for the actual grammar?

A

@StanFromIreland
Copy link
Member Author

StanFromIreland commented Aug 22, 2025

After all of the work put in to improve the snippets, I think it would be worse as the actual grammar would be much less reader friendly.

Furthermore, for this specific case the parsing is done by string_parser.c (IIRC the name) and is not explicitly defined in the grammar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir skip news
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants