Skip to content

Fix info about adding/removing feeds. #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2025

Conversation

rodrigogiraoserrao
Copy link
Contributor

One of the pages shows the correct info about using GH to add/edit/remove feeds while the other page shows a note about using an email address that isn't active right now (I know because I just wrote an email to that address requesting the change that I just proposed directly with PR #600.)

This PR replaces the old e-mail-based instructions with the new GH-based instructions.

Comment on lines 123 to 124
To request addition or removal:<br />
Open an issue on <a href="https://github.com/python/planet/issues">github</a><br />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A PR will get merged quicker :)

Maybe something like this?

Suggested change
To request addition or removal:<br />
Open an issue on <a href="https://github.com/python/planet/issues">github</a><br />
To request addition or removal,
<a href="https://github.com/python/planet">open a PR or issue</a>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I was just making it so that both pages (titles only and full content) have the same instructions.
I can go with your suggestion, but in that case I need to update both pages again.
Give me a second.

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hugovk hugovk merged commit db1ffed into python:main Aug 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants