Skip to content

fix ci import error #2876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 26, 2025
Merged

fix ci import error #2876

merged 5 commits into from
Aug 26, 2025

Conversation

liangel-02
Copy link
Contributor

No description provided.

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2876

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 422a9d3 with merge base 9f1e32b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 25, 2025
@liangel-02 liangel-02 changed the title fix import fix ci import error Aug 25, 2025
@liangel-02 liangel-02 added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Aug 25, 2025
@liangel-02 liangel-02 marked this pull request as ready for review August 25, 2025 22:52
danielvegamyhre
danielvegamyhre reviewed Aug 26, 2025
View reviewed changes
test/prototype/moe_training/test_fsdp.py Outdated
@@ -45,6 +45,12 @@
"torchtitan not installed, skipping MoE tests.", allow_module_level=True
)

if torch.version.hip is not None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this to test_tp.py and test_fsdp_tp.py as well?

danielvegamyhre
danielvegamyhre approved these changes Aug 26, 2025
View reviewed changes
Copy link
Contributor

@danielvegamyhre danielvegamyhre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Please make sure all CI is green for merging

petrex
petrex approved these changes Aug 26, 2025
View reviewed changes
Copy link
Collaborator

@petrex petrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see module level skip here. any plan to enable the test suite in the future?

@danielvegamyhre
Copy link
Contributor

I see module level skip here. any plan to enable the test suite in the future?

We would love to have AMD support in the future, but have no concrete plan/timeline for it. We are currently focused on B200 and H100 related workflows for PTC in October. If you'd like to contribute AMD support for MoE training code it would be welcome!

@liangel-02 liangel-02 merged commit 6a6a672 into main Aug 26, 2025
21 checks passed
@liangel-02 liangel-02 deleted the test_fsdp branch August 26, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrex petrex petrex approved these changes

@danielvegamyhre danielvegamyhre danielvegamyhre approved these changes

Assignees
No one assigned
Labels
ciflow/rocm ciflow/4xh100 CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm moe topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liangel-02 @danielvegamyhre @petrex