Fix inconsistent Pauli gate multiplication #7603
Open
+103
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhanced PauliString multiplication methods to handle GateOperations that can be interpreted as Pauli strings (e.g. X**2) by using the existing _try_interpret_as_pauli_string function. Addressed part of quantumlib#7588, for the PauliString * GateOperation cases, e.g. `x*x*x**2`
... to handle operations with single-item pauli expansions using PauliString. Addressed the GateOperation * GateOperation cases in quantumlib#7588.
ToastCheng
force-pushed
the
i7588-ps-impl
branch
from
d9f4abe to
fc2abac
Compare
github-actions
bot
added
size: M
github-actions
bot
added
size: S
...so that the PauliString construction logic in quantumlib#7588 is defined in a single function "_try_interpret_as_pauli_string".
ToastCheng
force-pushed
the
i7588-ps-impl
branch
from
85d3bc4 to
0247926
Compare
daxfohl
reviewed
Aug 26, 2025
1. Remove cases that have been handled in _mul_with_qubits 2. Remove try catch block in _try_interpret_as_pauli_string (quantumlib#7588)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7603 +/- ##
========================================
Coverage 97.50% 97.50%
========================================
Files 1101 1103 +2
Lines 99396 99714 +318
========================================
+ Hits 96913 97228 +315
- Misses 2483 2486 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
daxfohl
reviewed
Aug 27, 2025
daxfohl
reviewed
Aug 27, 2025
github-actions
bot
added
size: M
ToastCheng
commented
Aug 28, 2025
ToastCheng
force-pushed
the
i7588-ps-impl
branch
2 times, most recently
from
bd84d42 to
0579e62
Compare
... by trying to first convert the operation to be multiplied to a PauliString. With this change, the multiplication dunder function in pauli operation could be removed.
ToastCheng
force-pushed
the
i7588-ps-impl
branch
from
0579e62 to
6ea83a0
Compare
daxfohl
reviewed
Aug 28, 2025
Relax the type check from GateOperation to Operation.
...since it is unused now.
ToastCheng
force-pushed
the
i7588-ps-impl
branch
from
0837a45 to
a15cb41
Compare
Given that _try_interpret_as_pauli_string also handles PauliString after relaxing the type check to Operation, remove the PauliString type check here.
ToastCheng
force-pushed
the
i7588-ps-impl
branch
from
a52bd84 to
7a516c9
Compare
daxfohl
reviewed
Aug 29, 2025
daxfohl
approved these changes
Aug 29, 2025
There was a problem hiding this comment.
LGTM. Fixes the problem, and makes code more flexible and removes the need for special cases.
cc @pavoljuhas or @NoureldinYosri for maintainer review.
daxfohl
reviewed
Aug 29, 2025
| @@ -614,13 +614,13 @@ def _as_pauli_mask(val: Iterable[cirq.PAULI_GATE_LIKE] | np.ndarray) -> np.ndarr | |||
|
|
|||
|
|
|||
| def _attempt_value_to_pauli_index(v: cirq.Operation) -> tuple[int, int] | None: | |||
There was a problem hiding this comment.
@ToastCheng Note that this could easily be expanded now to return a list[tuple[int, int]] if v has multiple qubits, and allow DensePauliString to multiply and commute with parity gates etc on LineQubits too. I think that would be a separate PR, but would be a straightforward followup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that can be interpreted as Pauli strings (X2, Y2, Z**2, etc.)
operations with single-item pauli expansions using PauliString
This fixes #7588.