refactor: move focus to the last item when opening with ArrowUp #3642
+38
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #3640
Description
When the ArrowUp key is pressed on the DropdownMenu.Trigger component, the Content should open, and focus must move to the last item.
To implement this, I first created a state, wasOpenedWithArrowUp, to track when the menu is opened with the ArrowUp key.
Next, if wasOpenedWithArrowUp is true, the logic finds all enabled elements with role="menuitem" under the Content.
Finally, the focus() method is called on the last element in that list.