Skip to content

refactor: move focus to the last item when opening with ArrowUp #3642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

seongminn
Copy link

closed #3640

Description

When the ArrowUp key is pressed on the DropdownMenu.Trigger component, the Content should open, and focus must move to the last item.

To implement this, I first created a state, wasOpenedWithArrowUp, to track when the menu is opened with the ArrowUp key.
Next, if wasOpenedWithArrowUp is true, the logic finds all enabled elements with role="menuitem" under the Content.
Finally, the focus() method is called on the last element in that list.

Copy link

changeset-bot bot commented Jul 31, 2025

⚠️ No Changeset found

Latest commit: c1ea3e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DropdownMenu]: Keyboard Navigation doesn't work properly
1 participant