-
Notifications
You must be signed in to change notification settings - Fork 535
feat(nix): add mkShell
and flake
#580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say my reviews are helpful suggestion, I can't necessarily approve unless specifically the pkgs.mkShell
part is fix for compatibility and/or the flake-utils
usage
Sorry for taking a while to get back on this. It slipped through my schedule. |
Anything else that needs to happen before this can be merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes, personally I would apply.
" };", | ||
"", | ||
" outputs = inputs @ { self, nixpkgs, flake-utils, ... }: ", | ||
" flake-utils.lib.eachDefaultSystem (system: {", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please spit the systems up and recommend nix-systems to be used here.
snippets/nix.json
Outdated
" systems = [", | ||
" \"x86_64-linux\"", | ||
" \"aarch64-linux\"", | ||
" \"aarch64-darwin\"", | ||
" \"x86_64-darwin\"", | ||
" ];", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please recommend nix-systems to be used here.
Thanks for the review once again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.