Fix tool detection on Windows OS #179
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`command` is a unix shell builtin command which is not available on Windows, even in a MSYS2 enabled environment. This is because ruby runs the string passed to `Kernel.system` in a `cmd` shell, which doesn't know this command. But `where` is a proper replacement on Windows.
|
Looks like #176 is exactly the same solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commandis a unix shell builtin command which is not available on Windows, even in a MSYS2 enabled environment. This is because ruby runs the string passed toKernel.systemin acmdshell, which doesn't know this command. Butwhereis a proper replacement on Windows.With this change cssbundling-rails works out of the box on Windows with the Rubyinstaller and with yarn installed per pacman. And the unique feature is the unrivaled slowness that Windows offers even on fast hardware!