Skip to content

Map 'Caleb' to 'Caleb Buxton' #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

Conversation

cpb
Copy link
Contributor

@cpb cpb commented Sep 19, 2024

@cpb cpb force-pushed the add-missing-surname-to-caleb branch from 5a4363c to 3c34ded Compare March 2, 2025 03:12
@fxn
Copy link
Member

fxn commented Apr 16, 2025

Wow, sorry for the long delay. We normally merge this kind of PRs quickly, but it went off my radar.

@fxn fxn merged commit 8ffd814 into rails:main Apr 16, 2025
1 check passed
@fxn
Copy link
Member

fxn commented Apr 16, 2025

In production!

I saw "Caleb" having 4 commits, and "Caleb Buxton" having 6, so I expected 10 commits. However, we see 7.

Could it be the case that some were attributed to both handlers before?

@cpb
Copy link
Contributor Author

cpb commented Apr 16, 2025 via email

@fxn
Copy link
Member

fxn commented Apr 17, 2025

I've gone through the commits.

In rails/rails@21be844, rails/rails@80fda2a, and rails/rails@ffc1e5f, we have your full name as commit author, and also just "Caleb" in Co-authored-by. Before the mapping, the application assumed it was two people.

On the other hand, we went from 6 to 7 and rails/rails@5fa8793 is the 7th. That one was committed by Tobias Lütke and has "Caleb" credited in square brackets, old-style Subversion credit. So, this one is now mapped to your name too.

Therefore, it all squares!

@cpb
Copy link
Contributor Author

cpb commented Apr 17, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants