-
Notifications
You must be signed in to change notification settings - Fork 158
Map 'Caleb' to 'Caleb Buxton' #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5a4363c
to
3c34ded
Compare
Wow, sorry for the long delay. We normally merge this kind of PRs quickly, but it went off my radar. |
In production! I saw "Caleb" having 4 commits, and "Caleb Buxton" having 6, so I expected 10 commits. However, we see 7. Could it be the case that some were attributed to both handlers before? |
Yes I believe I noticed both handles attributed in the past.
Thank you very much for your attention to this!
When I take a closer look, if I notice anything off, I'll lead with a
failing test.
Thanks again!
…On Wed, Apr 16, 2025, 12:54 a.m. Xavier Noria ***@***.***> wrote:
In production!
I saw "Caleb" having 4 commits, and "Caleb Buxton" having 6, so I expected
10 commits. However, we see 7.
Could it be the case that some were attributed to both handlers before?
—
Reply to this email directly, view it on GitHub
<#310 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACSNXOFGT2Z6R7YY2U5N32ZYEDVAVCNFSM6AAAAABOQZQPKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBYG4YTONZUGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
*fxn* left a comment (rails/rails-contributors#310)
<#310 (comment)>
In production!
I saw "Caleb" having 4 commits, and "Caleb Buxton" having 6, so I expected
10 commits. However, we see 7.
Could it be the case that some were attributed to both handlers before?
—
Reply to this email directly, view it on GitHub
<#310 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACSNXOFGT2Z6R7YY2U5N32ZYEDVAVCNFSM6AAAAABOQZQPKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMBYG4YTONZUGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I've gone through the commits. In rails/rails@21be844, rails/rails@80fda2a, and rails/rails@ffc1e5f, we have your full name as commit author, and also just "Caleb" in On the other hand, we went from 6 to 7 and rails/rails@5fa8793 is the 7th. That one was committed by Tobias Lütke and has "Caleb" credited in square brackets, old-style Subversion credit. So, this one is now mapped to your name too. Therefore, it all squares! |
That's really thoughtful of you to double check so carefully! Thanks again!
…On Wed, Apr 16, 2025, 11:28 p.m. Xavier Noria ***@***.***> wrote:
I've gone through the commits.
In ***@***.***
<rails/rails@21be844>,
***@***.***
<rails/rails@80fda2a>,
and ***@***.***
<rails/rails@ffc1e5f>,
we have your full name as commit author, and also just "Caleb" in
Co-authored-by. Before the mapping, the application assumed it was two
people.
On the other hand, we went from 6 to 7 and ***@***.***
<rails/rails@5fa8793>
is the 7th. That one was committed by Tobias Lütke and has "Caleb" credited
in square brackets, old-style Subversion credit. So, this one is now mapped
to your name too.
Therefore, it all squares!
—
Reply to this email directly, view it on GitHub
<#310 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACSNVOA3SVMZUBGUYZAWD2Z5CYBAVCNFSM6AAAAABOQZQPKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJRHEYDMMBXGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
*fxn* left a comment (rails/rails-contributors#310)
<#310 (comment)>
I've gone through the commits.
In ***@***.***
<rails/rails@21be844>,
***@***.***
<rails/rails@80fda2a>,
and ***@***.***
<rails/rails@ffc1e5f>,
we have your full name as commit author, and also just "Caleb" in
Co-authored-by. Before the mapping, the application assumed it was two
people.
On the other hand, we went from 6 to 7 and ***@***.***
<rails/rails@5fa8793>
is the 7th. That one was committed by Tobias Lütke and has "Caleb" credited
in square brackets, old-style Subversion credit. So, this one is now mapped
to your name too.
Therefore, it all squares!
—
Reply to this email directly, view it on GitHub
<#310 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACSNVOA3SVMZUBGUYZAWD2Z5CYBAVCNFSM6AAAAABOQZQPKGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQMJRHEYDMMBXGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I've maintained the same email address, me@cpb.ca, as per: https://github.com/rails/rails/blob/5fa8793f02b58509a90eed69e8dc3d199f89b4ad/activerecord/CHANGELOG#L3
Thanks in advance!