Skip to content

Fix attribution for Andrew Novoselac #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
+5 −0
Merged

Fix attribution for Andrew Novoselac #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/models/names_manager/canonical_names.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ def self.map(canonical_name, *also_as)
map 'Andrew Evans', 'agius'
map 'Andrew Grim', 'stopdropandrew'
map 'Andrew Kaspick', "akaspick\100gmail.com", 'akaspick', "andrew\100redlinesoftware.com"
map 'Andrew Novoselac', "andrew.novoselac\100shopify.com"
map 'Andrew Peters', "andrew.john.peters\100gmail.com"
map 'Andrew Shcheglov', 'windock'
map 'Andrew White', 'pixeltrix'
Expand Down
4 changes: 4 additions & 0 deletions test/credits/canonical_names_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,10 @@ class CanonicalNamesTest < ActiveSupport::TestCase
assert_contributor_names 'd3cf2a6', 'Andrew Kaspick'
end

test "andrew.novoselac\100shopify.com" do
assert_contributor_names '0b8e083', "Andrew Novoselac"
end

test "andrey.nering\100gmail.com" do
assert_contributor_names '6d59473', 'Andrey Nering'
end
Expand Down
Loading