Skip to content

Utilize retryStrategy for connection error #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Utilize retryStrategy for connection error #1855

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d136813
Update Redis.ts
nodegin Feb 9, 2024
6b295e1
Fix wrong line
nodegin Feb 9, 2024
01f2747
Use this instead of self
nodegin Feb 9, 2024
8f6672a
Update Redis.ts
nodegin Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 21 additions & 11 deletions lib/Redis.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,18 +637,28 @@ class Redis extends Commander implements DataHandledable {
item.command.reject(err);
break;
case 2:
if (this.status !== "reconnecting") {
this.disconnect(true);
}
if (
this.condition?.select !== item.select &&
item.command.name !== "select"
) {
this.select(item.select);
const resendCommand = () => {
if (this.status !== "reconnecting") {
this.disconnect(true);
}
if (
this.condition?.select !== item.select &&
item.command.name !== "select"
) {
this.select(item.select);
}
// TODO
// @ts-expect-error
this.sendCommand(item.command);
};
if (typeof this.options.retryStrategy !== "function") {
return resendCommand();
}
// TODO
// @ts-expect-error
this.sendCommand(item.command);
const retryDelay = this.options.retryStrategy(++this.retryAttempts);
this.reconnectTimeout = setTimeout(() => {
this.reconnectTimeout = null;
resendCommand();
}, retryDelay);
break;
default:
item.command.reject(err);
Expand Down