-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[hadd] Improve verbosity settings #19707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 21 files 21 suites 3d 23h 23m 48s ⏱️ For more details on these failures, see this check. Results for commit 55e7f1d. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting some order in this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a step in the right direction. I believe that we need more flexibility for the Info
message, I proposed a solution (that still need more update to Info
calls).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment.
I agree on adding the multiple levels to Info(), but what about all the messages you didn't correct? Are those all |
I think that I already made some proposition inline, here is another stab:
|
d07a2df
to
6412dc8
Compare
new verbosity works like this: v0: only output errors v1: only output errors and warnings v2: output errors, warnings and TFileMerger messages v3: output all messages This is largely backwards-compatible as the default verbosity was and still is 99.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
New verbosity works like this:
v0: only output errors
v1: only output errors and warnings
v2: output errors, warnings and TFileMerger messages
v3: output all messages
This is largely backwards-compatible as the default verbosity was and still is 99.
One message (and one error!) were for some reason only emitted when verbosity was exactly 1, which makes no sense. This PR changes it to a regular Info() and Err() respectively. This means that by default hadd will now emit an additional message at the end of the merging process.
Checklist:
This PR fixes #19479