Add support for optional path segments #879
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spaceraccoon
force-pushed
the
spaceraccoon-add-optional-segments-handling
branch
from
4539dc6 to
96a39f4
Compare
spaceraccoon
force-pushed
the
spaceraccoon-add-optional-segments-handling
branch
from
96a39f4 to
ffbebd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for optional path segments in rails as per #878 by recursively including/excluding optional path segments in parentheses. Additionally, this modifies the
PathString.buildmethod due to the need to handle multiple possible paths per route, but respects the non-mutation paradigm.