Skip to content

Conversation

cristiand391
Copy link
Member

What does this PR do?

Fixes https://github.com/salesforcecli/temp-mcp-issues-transfer/issues/2

TODO:

  • ensure all parameters expecting paths specify if they should be absolute or relative
  • see if it's worth putting some validation using zod.refine to save chat turns (don't put validation inside the tool, we want to fail early).

What issues does this PR fix or reference?

@W-18951459@

@cristiand391 cristiand391 changed the title Cd/improve deploy prompt fix: improve prompts Jul 2, 2025
Look at your current Workspace Context to determine this filepath.
ALWAYS USE A FULL PATH TO THE DIRECTORY.
Unless the user explicitly asks for a different directory, or a new directory is created from the action of a tool, use this same directory for future tool calls.
Use the full absolute path to the root directory of the active project in the current IDE workspace context.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want to reference IDE in this context. The mcp server can be used in different applications which would not be recognized as IDE by the agent. For example openai/codex or google-gemini/gemini-cli. This could confuse the agent.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call.
While MCPs could be used in any app that supports it, at least for this server we are making some assumptions about the kind of MCP client users are in (IDEs, CLI agent tools like you mentioned), I'll take a look at some open source client prompts to see if there's something else that can improve this param description.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, MCP roots could help remove the inference step when figuring out the open project directory but support in clients it's not good enough yet:
https://modelcontextprotocol.io/clients

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants