Skip to content

Conversation

phlogistonjohn
Copy link
Collaborator

Update the PyPI section of the release process doc to use a path that is more consistent with the sections above. Remove a reference to a username prompt as newer versions of twine no longer prompt for a username and require a token.

avanthakkar
avanthakkar previously approved these changes Sep 4, 2025
Copy link
Collaborator

@avanthakkar avanthakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, but I have spotted some (potential) typos. (see inline.)

Update the PyPI section of the release process doc to use a path
that is more consistent with the sections above. Remove a reference
to a username prompt as newer versions of twine no longer prompt
for a username and require a token.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
@mergify mergify bot dismissed avanthakkar’s stale review September 4, 2025 12:11

Pull request has been modified.

@obnoxxx
Copy link
Contributor

obnoxxx commented Sep 4, 2025

@Mergifyio refresh

Copy link

mergify bot commented Sep 4, 2025

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 52a3e01 into samba-in-kubernetes:master Sep 4, 2025
10 checks passed
@phlogistonjohn phlogistonjohn deleted the jjm-rel-doc-pypi branch September 4, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants