Warn unused masking imports, remove obsolete unused options #23757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha, somewhere in my backlog of useful PRs is a fix to the test rig so that is handled correctly. I ought to have deleted the line anyway. |
som-snytt
force-pushed
the
cleanup/unused
branch
from
a57d148 to
ca19213
Compare
som-snytt
force-pushed
the
cleanup/unused
branch
from
ca19213 to
5991804
Compare
som-snytt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete the old option to guard against false positives. It was a backstop for the new feature.
The option was left in 3.7 for compatibility but should be removed for 3.8.
Delete old consideration of
CanEqual, since the current feature does not warn about "marker interfaces". (Edit: actually that needs work to probe for candidateCE; that sounds workable, since it's not implicit search per seA "masking" selector
import a.b as _is considered "used" if the import includes a wildcard and the import was interrogated for the masked name.Fixes #23758