-
Notifications
You must be signed in to change notification settings - Fork 90
fix: Add temporary upper bounds on NumPy and SciPy to pass tests #2592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 0b352ca.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2592 +/- ##
==========================================
+ Coverage 98.21% 98.23% +0.02%
==========================================
Files 69 69
Lines 4543 4545 +2
Branches 804 612 -192
==========================================
+ Hits 4462 4465 +3
Misses 48 48
+ Partials 33 32 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bypassing rules as docs are expected to fail and will be fixed in a different PR. |
Description
To get development up and running again without having to deal with additional changes yet to the codebase, just get the existing code passing without changing library code and then go from there. We should then pull in the parts of @kratsg's PR #2566 that are needed. Docs will get fixed in another PR.
Resolves #2553
click.testing.CliRunner
to work with versions of Click older than v8.2.0.--enable-cuda
flag that can be passed to let CUDA backends be turned on.pyhf
CLI command with no arguments from Docker image test as it results in an exit code of 2.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: