Refactor notification system for common interface and security #3228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, DingTalk Co-authored-by: denguk <denguk@gmail.com>
|
Cursor Agent can help with this pull request. Just |
Co-authored-by: denguk <denguk@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the notification system to introduce a common interface, secure token-based configurations, and project-specific settings for Telegram, Slack, Gotify, and Dingtalk, while preserving backward compatibility.
The previous notification system relied on insecure URL parameters and lacked a unified interface, making it difficult to extend and manage. This refactoring addresses these issues by providing a secure, extensible, and project-configurable notification framework. It ensures existing configurations continue to function by running both old and new systems in parallel.