Skip to content

Fix: version matching regex to handle uppercase 'V' #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dorage
Copy link

@dorage dorage commented Aug 17, 2025

Summary

-There was an issue where the update available button kept showing because version matching failed due to the remaining 'V' prefix

Changes

  • Modified the regex pattern in useVersionCheck.js from /^v/ to /^[v|V]/ to properly handle version tags that start with uppercase 'V'

Test plan

  • Test with version tags starting with 'v' (e.g., v1.0.0)
  • Test with version tags starting with 'V' (e.g., V1.0.0)
  • Verify version comparison works correctly in both cases

🤖 Generated with Claude Code

Before
ScreenShot Tool -20250817105210
After
ScreenShot Tool -20250817105730

@dorage dorage changed the title Fix version matching regex to handle uppercase 'V' Fix: version matching regex to handle uppercase 'V' Aug 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant