Skip to content

Use own interface for Socket request to allow extending the request interface independently of Express. #4787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use own interface for Socket request to allow extending the request interface independently of Express. #4787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1136,4 +1136,4 @@ export {
BroadcastOperator,
RemoteSocket,
};
export { Event } from "./socket";
export { Event, SocketRequest } from "./socket";
4 changes: 3 additions & 1 deletion lib/socket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ export const RESERVED_EVENTS: ReadonlySet<string | Symbol> = new Set<
"removeListener",
]);

export interface SocketRequest extends IncomingMessage {}

/**
* The handshake details
*/
Expand Down Expand Up @@ -990,7 +992,7 @@ export class Socket<
/**
* A reference to the request that originated the underlying Engine.IO Socket.
*/
public get request(): IncomingMessage {
public get request(): SocketRequest {
return this.client.request;
}

Expand Down