Remove returns that don't do anything (addresses #8) #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfe-SparkFro
approved these changes
May 28, 2025
|
Actually, let's hold on a v2.1 release until we look at #9 and other outstanding issues for low hanging fruit. |
sfe-SparkFro
requested changes
May 29, 2025
Comment on lines
197
to
-212
| def begin(self): | ||
| """! | ||
| Initialize the operation of the SerLCD module | ||
|
|
||
| @return **bool** Returns true if the initialization was successful, otherwise False. | ||
| """ | ||
| # set default settings, as defined in constructor | ||
| result0 = self.specialCommand(LCD_DISPLAYCONTROL | self._displayControl) | ||
| self.specialCommand(LCD_DISPLAYCONTROL | self._displayControl) | ||
| time.sleep(1) | ||
| result1 = self.specialCommand(LCD_ENTRYMODESET | self._displayMode) | ||
| self.specialCommand(LCD_ENTRYMODESET | self._displayMode) | ||
| time.sleep(1) | ||
| result2 = self.clearScreen() | ||
| self.clearScreen() | ||
| time.sleep(1) | ||
|
|
||
| return (bool(result0) & bool(result1) & bool(result2)) | ||
|
|
There was a problem hiding this comment.
Should first check is_connected(). If it fails, return False immediately. Otherwise, proceed as before and return True.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove useless returns brought up in #8