starknet_os: encrypt data availability

[noaov1]

No description provided.

[reviewable-StarkWare]

This change is 

[einat-starkware]

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)

---

crates/starknet_os/src/hints/enum_definition.rs line 826 at r2 (raw file):

    ),
    (
        SetEncryptedStart,

Note that adding a new hint will break the unused hint test in python, so you will need to open a pyside PR as well

[Yoni-Starkware]

@Yoni-Starkware reviewed 1 of 5 files at r1.
Reviewable status: 1 of 5 files reviewed, 3 unresolved discussions (waiting on @einat-starkware and @noaov1)

---

crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/output.cairo line 267 at r2 (raw file):

    if (n_keys == 0) {
        return (da_start=compressed_start, da_end=compressed_dst);
    }

Suggestion:

    if (n_keys == 0) {
        // No public keys - skip the state updates encryption.
        return (da_start=compressed_start, da_end=compressed_dst);
    }

---

crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/output.cairo line 278 at r2 (raw file):

            # Assign a temporary segment, to be relocated into the output segment.
            ids.encrypted_start = segments.add_temp_segment()
    %}

Move this hint right above the use in encrypted_dst

Suggestion:

    local encrypted_start: felt*;
    %{
        if use_kzg_da:
            ids.encrypted_start = segments.add()
        else:
            # Assign a temporary segment, to be relocated into the output segment.
            ids.encrypted_start = segments.add_temp_segment()
    %}
    
    let encrypted_dst = encrypted_start;

[Yoni-Starkware]

Reviewable status: 1 of 5 files reviewed, 5 unresolved discussions (waiting on @einat-starkware and @noaov1)

---

crates/starknet_os/src/hints/hint_implementation/output.rs line 147 at r2 (raw file):

        x if x == Felt::ZERO => Ok(false),
        _ => Err(OsHintError::BooleanIdExpected { id: Ids::UseKzgDa, felt: use_kzg_da_felt }),
    }?;

Please share this code (felt_to_bool)

Code quote:

    let use_kzg_da = match use_kzg_da_felt {
        x if x == Felt::ONE => Ok(true),
        x if x == Felt::ZERO => Ok(false),
        _ => Err(OsHintError::BooleanIdExpected { id: Ids::UseKzgDa, felt: use_kzg_da_felt }),
    }?;

---

crates/starknet_os/src/hints/hint_implementation/output.rs line 149 at r2 (raw file):

    }?;

    if use_kzg_da || n_keys > Felt::ZERO {

Extract the insert_value_from_var_name outside the if-else. Also in the other hint

[noaov1]

Reviewable status: 1 of 5 files reviewed, 3 unresolved discussions (waiting on @einat-starkware and @Yoni-Starkware)

---

crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/output.cairo line 278 at r2 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Move this hint right above the use in encrypted_dst

Done.

---

crates/starknet_os/src/hints/hint_implementation/output.rs line 147 at r2 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Please share this code (felt_to_bool)

Done.

[github-actions]

Artifacts upload workflows:

• Started at 2025-09-15T14:23:11Z

[github-actions]

Benchmark movements: No major performance changes detected.

[Yoni-Starkware]

@Yoni-Starkware reviewed 1 of 1 files at r2, 3 of 3 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @einat-starkware and @noaov1)

---

crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/output.cairo line 278 at r2 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Done.

Move this entire block above with encrypted_dst {... (non blocking)