Fix favicon configuration bug #1983
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
let the developer know they need to install formik to run this example
Blocks improvements: moving blocks & expand field
* Mention grouping * Update badge * Update docusaurus/docs/user-docs/releases/introduction.md * chore: update screenshot and add callout for beta version (strapi#1972) * Move beta callout to grouping section * Update docusaurus/docs/user-docs/releases/managing-a-release.md Co-authored-by: markkaylor <mark.kaylor@strapi.io> * Update docusaurus/docs/user-docs/releases/managing-a-release.md --------- Co-authored-by: markkaylor <mark.kaylor@strapi.io>
This reverts commit 0a446e0.
Because I tested this example to replace the favicon, and I've got an error.
```bash
yarn run v1.22.19
$ strapi build
⠋ Building build context
[INFO] Including the following ENV variables as part of the JS bundle:
- ADMIN_PATH
- STRAPI_ADMIN_BACKEND_URL
- STRAPI_TELEMETRY_DISABLED
✔ Building build context (73ms)
⠋ Building admin panel
⠴ Building admin panel[ERROR] Module not found: Error: Can't resolve './extensions/favicon.png' in '/var/www/strapi/src/admin'
✖ Building admin panel
[ERROR] There seems to be an unexpected error, try again with --debug for more information
error Command failed with exit code 1.
```
…size to config instructions (strapi#2132) * Add info about nginx max file size to config instructions * Update docusaurus/docs/dev-docs/deployment/digitalocean.md --------- Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com>
* Add new icons in project settings page * Add icon for Variables * Update documentation for Profile > Billing * Add documentation for Settings > Plans * Add new icons in Profile settings page + some improvements * Update/add documentation about Invoices * Add comments to update screenshots at the end of the project * Change Usage & Billing name everywhere + start documenting seats management * Document seats management * Create + Use snippet for invoices statuses info * Update TOC badges * Fix typos and errors after reviews * Update & add screenshots --------- Co-authored-by: Pierre Wizla <pwizla@users.noreply.github.com>
* Update to Cloud CLI docs re. connecting a git repo. * Add mention for all deploy. methods * Fix heading link * Update deploys intro.
feat(cli): strapi projects
pwizla
requested review from
derrickmehaffy and
meganelacheny
as code owners
pwizla
force-pushed
the
main
branch
2 times, most recently
from
25723df to
63466f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
The configuration in the documentation for changing the favicon is not functioning properly. I have updated a method that works well.
Why is it needed?
Mitigated a bug.
Related issue(s)/PR(s)
Details about the bug can be found at strapi/strapi#19238.