Add full 2D array support #259
Open
+254
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit resolves fundamental array issues in shecc and implements
complete support for multi-dimensional arrays with proper row-major
indexing.
1. Fix array value storage and retrieval
- Arrays now correctly store and return values (was always 1)
- Added spill_var call in register allocator to store base addresses
- Arrays properly behave as pointers to their first element
2. Implement full 2D array support with row-major indexing
- Added array_dim1 and array_dim2 fields to track dimensions
- Parser now preserves dimension information for multi-dimensional
arrays
- Fixed indexing calculation: matrix[i][j] correctly maps to
base + i*cols + j
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit resolves fundamental array issues in shecc and implements complete support for multi-dimensional arrays with proper row-major indexing.
Summary by Bito
This pull request enhances the shecc compiler with full support for 2D arrays, resolving issues with value storage and retrieval. It implements row-major indexing and updates the parser and register allocator for better management of multi-dimensional arrays. Comprehensive tests have been added to validate the new functionality.