logout when restart the server #718

sug-ghosh · 2025-07-01T17:06:41Z

Description

fixes #717

Features Implemented

15-minute Session Timeout

Backend: JWT tokens now expire after 15 minutes instead of 24 hours
Frontend: Client-side session management tracks user activity and automatically logs out after 15 minutes of inactivity
Activity Detection: Mouse movements, clicks, keyboard input, scrolling, and touch events reset the timeout

Server Restart Detection

Backend: JWT tokens include a server start timestamp claim
Frontend: Checks server start time on every API call to detect server restarts immediately
Automatic Logout: Users are automatically logged out on any action after server restart

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required, with the following suggested text:

* Fix some things.

sug-ghosh · 2025-07-01T17:12:02Z

@mosabua @ebyhr please review this pr for logout users when Trino-gateway server restarts.

Chaho12 · 2025-07-01T23:40:59Z

gateway-ha/src/main/java/io/trino/gateway/ha/security/LbFormAuthManager.java

@@ -38,6 +40,8 @@
 public class LbFormAuthManager
 {
    private static final Logger log = Logger.get(LbFormAuthManager.class);
+    private static final long SERVER_START_TIME = System.currentTimeMillis();
+    private static final int SESSION_TIMEOUT_MINUTES = 15;


Is there a specific reason for 15 min? If not, why don't we make this configurable? + docs would be welcome :)

@Chaho12 mostly pentester recommend 15 minutes for UI session. That's why. otherwise I can make it configurable. and which docs I should update?

Since Tomcat, Spring is 30 min, i thought 30 min was default.
https://trinodb.github.io/trino-gateway/security/ this page sounds fit.

@Chaho12 okay, I will make this 30. and do I make this configurable as well?

let's make this configurable

also, please use airlift's Duration class

andythsu · 2025-07-02T13:46:08Z

gateway-ha/src/main/java/io/trino/gateway/ha/resource/LoginResource.java

+        if (formAuthManager != null) {
+            // Get server start time from form auth manager
+            try {
+                java.lang.reflect.Field field = formAuthManager.getClass().getDeclaredField("SERVER_START_TIME");


let's not use reflection for this

andythsu · 2025-07-02T13:47:02Z

gateway-ha/src/main/java/io/trino/gateway/ha/security/LbFormAuthManager.java

@@ -38,6 +40,8 @@
 public class LbFormAuthManager
 {
    private static final Logger log = Logger.get(LbFormAuthManager.class);
+    private static final long SERVER_START_TIME = System.currentTimeMillis();


if this is intended to be shared by multiple classes, we can move it out from this class and then create a separate config class. OR we can create a getter for this field

andythsu · 2025-07-02T13:47:09Z

gateway-ha/src/main/java/io/trino/gateway/ha/security/LbFormAuthManager.java

@@ -38,6 +40,8 @@
 public class LbFormAuthManager
 {
    private static final Logger log = Logger.get(LbFormAuthManager.class);
+    private static final long SERVER_START_TIME = System.currentTimeMillis();
+    private static final int SESSION_TIMEOUT_MINUTES = 15;


let's make this configurable

andythsu · 2025-07-02T13:47:39Z

gateway-ha/src/main/java/io/trino/gateway/ha/security/LbFormAuthManager.java

@@ -38,6 +40,8 @@
 public class LbFormAuthManager
 {
    private static final Logger log = Logger.get(LbFormAuthManager.class);
+    private static final long SERVER_START_TIME = System.currentTimeMillis();
+    private static final int SESSION_TIMEOUT_MINUTES = 15;


also, please use airlift's Duration class

andythsu · 2025-07-02T13:52:50Z

gateway-ha/src/main/java/io/trino/gateway/ha/security/LbFormAuthManager.java

@@ -105,6 +109,21 @@ public Optional<Map<String, Claim>> getClaimsFromIdToken(String idToken)
            DecodedJWT jwt = JWT.decode(idToken);

            if (LbTokenUtil.validateToken(idToken, lbKeyProvider.getRsaPublicKey(), jwt.getIssuer(), Optional.empty())) {
+                // Check if token was issued before server restart
+                Claim serverStartClaim = jwt.getClaim("server_start");


can we wrap it in Optional so it's clear that it's nullable?

andythsu · 2025-07-02T13:53:53Z

gateway-ha/src/main/java/io/trino/gateway/ha/security/LbFormAuthManager.java

+                    }
+                }
+                // Check token expiration
+                Date expiresAt = jwt.getExpiresAt();


can we wrap it in Optional so it's clear that it's nullable?

@andythsu I have resolved other comments in this forced pushed pr.

andythsu · 2025-07-02T13:55:52Z

webapp/src/api/base.ts

+                }
+            } catch (error) {
+                // Token validation failed, user will be logged out
+                throw error;


Are we doing anything in catch? Otherwise it may be unnecessary to catch the error

@andythsu yes, we are throwing error as token validation failed and user will be logged out in that case

andythsu · 2025-07-02T14:03:02Z

webapp/src/store/access.ts

+                }
+            } catch (error) {
+                console.error('Error checking server info:', error);
+                // Don't logout on API error, just continue


should we log out here? technically we should never end up in this state, but if we do, it means the server is having issues.

@andythsu No, we are not logging out here, we are logging the server error here

sug-ghosh · 2025-07-07T08:45:14Z

@andythsu can you please review once?

mosabua · 2025-07-11T06:16:19Z

As it stands this change is not useful. Users should NOT be logged out just because one Trino Gateway server shuts down. Trino Gateway can run as a cluster and users should not be logged out but instead remain active and continue to be able to use everything.

sug-ghosh · 2025-07-11T06:58:51Z

As it stands this change is not useful. Users should NOT be logged out just because one Trino Gateway server shuts down. Trino Gateway can run as a cluster and users should not be logged out but instead remain active and continue to be able to use everything.

Hello @mosabua , understand, will it be helpful if I discard the changes related to logout in server detection and keep the changes of 30 minute session timeout if user remains idle. Can this be taken if Trino Gateway Run as a cluster?

mosabua · 2025-07-12T03:20:31Z

Yes .. I think an idle logout might still be a good thing .. as long as it also works if Trino Gateway runs as cluster

sug-ghosh · 2025-07-18T07:34:19Z

Hello @mosabua if you suggesting Gateway run as a cluster means, HA proxy above gateway cluster, then the above changes works fine. I have already validated that. If one of the server restarts it does not throw away users logged off. only if HA cluster is restarted then only it logged off the user for a new session.

cla-bot bot added the cla-signed label Jul 1, 2025

sug-ghosh requested review from ebyhr and mosabua July 1, 2025 17:10

Chaho12 reviewed Jul 1, 2025

View reviewed changes

andythsu suggested changes Jul 2, 2025

View reviewed changes

logout when restart the server

17b9b8b

sug-ghosh force-pushed the feature/logout branch from 7e649d9 to 17b9b8b Compare July 3, 2025 16:59

sug-ghosh requested a review from andythsu July 3, 2025 17:00

sug-ghosh requested a review from Chaho12 July 8, 2025 04:27

logout when restart the server #718

Are you sure you want to change the base?

logout when restart the server #718

Uh oh!

Conversation

sug-ghosh commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Additional context and related issues

Release notes

Uh oh!

sug-ghosh commented Jul 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sug-ghosh commented Jul 7, 2025

Uh oh!

mosabua commented Jul 11, 2025

Uh oh!

sug-ghosh commented Jul 11, 2025

Uh oh!

mosabua commented Jul 12, 2025

Uh oh!

sug-ghosh commented Jul 18, 2025

Uh oh!

Uh oh!

sug-ghosh commented Jul 1, 2025 •

edited

Loading