Fix: rename and implement fallbackRenderMethod #20005
Merged
+36
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR renames the defaultRenderMethod property to fallbackRender across block editor components and implements it consistently for all Block Editors. The change addresses potential confusion between "default" rendering behavior and fallback rendering when no custom extensions are available.
Key changes:
- Renamed
defaultRenderMethodtofallbackRenderfor clarity - Implemented
fallbackRenderproperty in both extension slot components - Updated all block editor components to use the new property consistently
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| extension-with-api-slot.element.ts | Added fallbackRender property and renderNoting helper method |
| extension-slot.element.ts | Renamed defaultRenderMethod to fallbackRender and refactored rendering logic |
| block-rte-entry.element.ts | Updated to use fallbackRender with new renderBuiltinBlockView method |
| block-list-entry.element.ts | Converted renderBuiltinBlockView to arrow function and updated extension slot usage |
| block-grid-entry.element.ts | Updated to use fallbackRender property instead of defaultRenderMethod |
1 task
nielslyngsoe
changed the title
iOvergaard
deleted the
v16/feature/rename-extension-slot-fallback-render
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue the work of #19962
To ensure its implemented for all Block Editors and rename the method to
fallbackRenderto avoid misunderstanding withdefault.