Update dependencies #851
Draft
Update dependencies #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chippmann
force-pushed
the
feature/update-dependencies
branch
from
00a9d21 to
11c86d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates all our depedencies and crucially enables us to finally update kotlin poet because square/kotlinpoet#1759 seems to no longer affect us.
This means all return types must be explicitly specified.
The huge changeset stems from the new kotlin poet version as kotlin poet no longer auto generates line breaks inbetween. So putting
·everywhere we want no line change is no longer necessary (but existing code must not be changes as this change is backwards compatible. Hence i did not touch this at all for now).