Skip to content

Conversation

pront
Copy link
Member

@pront pront commented Aug 22, 2025

Summary

  • Env vars are renamed during test generation
  • They are now passed to docker build
  • The real fix: we now resolve docker volume paths before modifying their metadata

Vector configuration

How did you test this PR?

ran existing tests

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • cargo fmt --all
      • cargo clippy --workspace --all-targets -- -D warnings
      • cargo nextest run --workspace (alternatively, you can run cargo test --all)
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run cargo vdev build licenses to regenerate the license inventory and commit the changes (if any). More details here.

@pront pront requested a review from a team as a code owner August 22, 2025 18:24
@github-actions github-actions bot added the domain: vdev Anything related to the vdev tooling label Aug 22, 2025
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Aug 22, 2025
@pront pront enabled auto-merge August 22, 2025 18:47
@pront pront added this pull request to the merge queue Aug 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 22, 2025
@pront pront enabled auto-merge August 25, 2025 14:19
@pront pront disabled auto-merge August 25, 2025 16:39
@pront pront enabled auto-merge August 25, 2025 22:01
@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Aug 25, 2025

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8159cde | Docs | Was this helpful? Give us feedback!

@pront pront added this pull request to the merge queue Aug 25, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 25, 2025
@pront pront added this pull request to the merge queue Aug 26, 2025
@pront pront removed this pull request from the merge queue due to a manual request Aug 26, 2025
@pront pront enabled auto-merge August 26, 2025 02:22
@pront pront added this pull request to the merge queue Aug 26, 2025
Merged via the queue into master with commit 1601ff2 Aug 26, 2025
86 checks passed
@pront pront deleted the pront-vdev-resolve-paths-and-build branch August 26, 2025 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: vdev Anything related to the vdev tooling no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants