Migrates remaining tests to github runners #1106
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you are just trying things out and PR is not ready for review, please mark it as draft |
moharaka
force-pushed
the
migrating-remaining-unit-test
branch
7 times, most recently
from
78f949e to
170f8b0
Compare
moharaka
force-pushed
the
migrating-remaining-unit-test
branch
14 times, most recently
from
ce2b691 to
3cacaf8
Compare
moharaka
force-pushed
the
migrating-remaining-unit-test
branch
from
74ea326 to
6e7f0cb
Compare
| @@ -6,12 +6,12 @@ spec: | |||
| template: | |||
| spec: | |||
| containers: | |||
| - image: ghcr.io/ease-lab/helloworld:var_workload | |||
| - image: ghcr.io/ease-lab/helloworld@sha256:12dc6715ed1a8306f246ceaf7742c09e38a52a79d17421e4a50d7e0e09fdbc25 | |||
There was a problem hiding this comment.
Why do you need to change that?
Comment on lines
61
to
63
| sudo kubectl get deployment -n knative-serving autoscaler | ||
| sudo kubectl get svc -n knative-serving autoscaler | ||
| sudo kubectl get pods -n kube-system -l k8s-app=kube-dns |
There was a problem hiding this comment.
Right now, tests fail here. You forgot the KUBECONFIG env var.
| @@ -51,7 +51,7 @@ jobs: | |||
|
|
|||
| - name: Run sandbox specific tests | |||
| if: ${{ inputs.sandbox == 'firecracker' }} | |||
| run: source /etc/profile && go clean -testcache && go test ./cri/${{ inputs.sandbox }} -v -race -cover | |||
| run: source /etc/profile && go clean -testcache && sudo go test ./cri/${{ inputs.sandbox }} -v -race -cover | |||
There was a problem hiding this comment.
Why do you need sudo here?
moharaka
force-pushed
the
migrating-remaining-unit-test
branch
5 times, most recently
from
6807ba3 to
f599777
Compare
moharaka
force-pushed
the
migrating-remaining-unit-test
branch
5 times, most recently
from
a657619 to
2cc604a
Compare
Signed-off-by: Mohamed L. Karaoui <moharaka@gmail.com>
moharaka
force-pushed
the
migrating-remaining-unit-test
branch
6 times, most recently
from
550c33b to
af51cc3
Compare
Signed-off-by: Mohamed L. Karaoui <moharaka@gmail.com>
moharaka
force-pushed
the
migrating-remaining-unit-test
branch
2 times, most recently
from
6efe7d3 to
b999734
Compare
Signed-off-by: Mohamed L. Karaoui <moharaka@gmail.com>
moharaka
force-pushed
the
migrating-remaining-unit-test
branch
from
b999734 to
1919f0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrates remaining tests to github runners
Implementation Notes ⚒️
Approach: first replace all self-hosted to ubuntu and debug.
External Dependencies 🍀
N/A
Breaking API Changes⚠️
*N/A
Simply specify none (N/A) if not applicable.