Fix SynchronousOnlyOperation error if @paginate with async view returns Django queryset
#1293
+121
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to run async for loop for django queryset
qodot
changed the title
SynchronousOnlyOperation error when paginate is used with async views returning Django querysets.SynchronousOnlyOperation error if @paginate with async view returns Django queryset
michalasia10
reviewed
Jan 3, 2025
| ) | ||
|
|
||
| async def evaluate(results: Union[List, QuerySet]) -> AsyncGenerator: | ||
| for result in results: |
There was a problem hiding this comment.
This can be fixed by just adding async to this for loop.
Anyway, bump beacuse I had also this issue ;d
@vitalik pls check this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying the
paginatedecorator to an async view that returns a Django queryset, aSynchronousOnlyOperationerror occurs. (cause ofdjango-ninja/ninja/pagination.py
Lines 206 to 208 in 457c066
To resolve this, I've added
_inject_async_paginationwithin thepaginateandRouterPaginatedand differentiated the behavior based on the view type.