Skip to content

fix(date): allow configure i18n when using custom adapter #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(date): allow configure i18n when using custom adapter #265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/runtime/plugins/date.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import type { VuetifyOptions } from 'vuetify'
import { useNuxtApp } from '#imports'

export function configureDate(vuetifyOptions: VuetifyOptions) {
if (adapter === 'custom' || !enabled)
return
// if (adapter === 'custom' || !enabled)
// return

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be

if (!enabled)
    return

?

Copy link
Author

@mmnoori mmnoori Aug 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am using i18n.
i just know when vuetifyOptions.date.adapter is NOT set to 'custom',
configureDate plugin won't change date localization.
I assume your code is right 👍👍👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmnoori can you explain the problem? changing the code with my previous suggestion will fix the problem you're trying to solve?

const dateOptions = dateConfiguration()

Expand Down