Update `discord.js` to latest version #59

FranjoMindek · 2025-08-20T13:54:41Z

Updates discord.js from v12 to v14.
This also updates Discord API from v8 to v10.
Discord API v8 is deprecated.

Logic behind changes is explain on the changed files themselves.

FranjoMindek · 2025-08-20T13:55:47Z

src/analytics/cli.ts

@@ -91,6 +90,5 @@ function printAllTimeMonthlyReportCsvInCLI(
 }

 cliReport().catch((e) => {
-  const message = getAnalyticsErrorMessage(e);


We should let the logger get the error object rather than message.
It has built in formatters to handle errors itself. No need to do it ourselves.

src/discord/bot/analytics/commands.ts

FranjoMindek · 2025-08-20T13:57:57Z

src/discord/bot/analytics/commands.ts

@@ -22,22 +22,21 @@ function isReportsChannel(channel: Discord.Channel): boolean {
 }

 export async function handleAnalyticsCommand(
-  discordClient: Discord.Client,


We receive the Discord.Client object inside of the message object.
No need to pass it by ourselves.

Moreover, message.client'sDiscord.Client is sure to be ready (Discord.Client<true>).
This ensures some types don't have the optional flag anymore.

src/discord/bot/index.ts

FranjoMindek · 2025-08-20T14:04:05Z

src/discord/bot/index.ts

-    if (isOurDiscordBotMessage(discordClient, message)) {
-      return;
-    }
+  await discordClient.login(BOT_TOKEN);


This is async, we should await and make start an async function.
Then the caller can decide if to await or not.
Like this the caller has no choice to await.

FranjoMindek · 2025-08-20T14:04:45Z

src/discord/bot/index.ts

-      await handleAnalyticsCommand(discordClient, message);
-    }
+async function handleGuildMessage(message: Discord.Message): Promise<void> {
+  if (message.author.bot) {


Don't handle any bot. That includes this bot itself.

src/discord/bot/index.ts

src/discord/bot/introduction.ts

src/discord/utils.ts

FranjoMindek · 2025-08-21T07:38:40Z

src/discord/bot/analytics/common.ts

    embed.setImage(report.imageChartsChart.toURL());
-    options.embed = embed;
+    options.embeds = [embed];


discord.js now supports up to 10 embeds, hence plural.

src/discord/bot/analytics/common.ts

FranjoMindek · 2025-08-21T08:18:39Z

src/discord/bot/analytics/daily-report.ts

    await reportsChannel.send(
-      `Failed to send daily analytics report: ${message}`,
+      `Failed to send daily analytics report. Check the logs for more details.
+      https://fly-metrics.net/d/fly-logs/fly-logs?orgId=273532&var-app=wasp-bot`,


The message was never really to helpful.
I've added a link to our wasp-bot graphana so we can easily check the logs.

FranjoMindek · 2025-08-21T08:19:19Z

src/discord/bot/index.ts

+      Discord.GatewayIntentBits.Guilds,
+      Discord.GatewayIntentBits.GuildMessages,
+      Discord.GatewayIntentBits.GuildMembers,
+      Discord.GatewayIntentBits.MessageContent,


We have to add those intents to our bot's settings on Discord's developers portal.
Otherwise we will error on startup.

Classic comment, but I'd add this to the code itself for the future when people update the code to go and update the settings.

src/utils/logger.ts

cprecioso

Overall LGTM, left some comments

src/discord/bot/analytics/commands.ts

src/discord/utils.ts

src/utils/logger.ts

src/discord/bot/analytics/common.ts

src/discord/bot/index.ts

-    if (isOurDiscordBotMessage(discordClient, message)) {
-      return;
-    }
+  await discordClient.login(BOT_TOKEN);


src/discord/bot/index.ts

src/discord/bot/introduction.ts

src/discord/bot/analytics/common.ts

src/types/discord-js.ts

src/discord/bot/introduction.ts

src/discord/types.ts

infomiho

Left some comments

infomiho · 2025-09-08T11:33:16Z

src/discord/bot/index.ts

+      Discord.GatewayIntentBits.Guilds,
+      Discord.GatewayIntentBits.GuildMessages,
+      Discord.GatewayIntentBits.GuildMembers,
+      Discord.GatewayIntentBits.MessageContent,


Classic comment, but I'd add this to the code itself for the future when people update the code to go and update the settings.

infomiho · 2025-09-08T11:34:36Z

src/discord/bot/index.ts

-
-    await handleMessage(newMessage);
-  });
+  // Messages sent in DM channels


Suggested change

// Messages sent in DM channels

// Ignore messages sent in the DM channels

infomiho · 2025-09-08T11:36:15Z

src/discord/bot/index.ts

+    ],
+  });
+
+  discordClient.on(Discord.Events.ClientReady, (readyDiscordClient) => {


Suggested change

discordClient.on(Discord.Events.ClientReady, (readyDiscordClient) => {

discordClient.on(Discord.Events.ClientReady, (startedDiscordClient) => {

Nitpick: the ready adjective can also read as a verb so it confused me for a second if this is a function or a "Discord client that is ready", so I think we maybe can improve the name here. Offered my suggestion above.

Hm, I use ready since that is what discord.js uses, and I didn't want to introduce another domain context. But since this is really local we could go with started.

infomiho · 2025-09-08T11:38:35Z

src/discord/bot/introduction.ts

-  return !!member?.roles.cache.get(GUEST_ROLE_ID);
+async function isGuestUser(message: GuildMessage): Promise<boolean> {
+  const member = await message.guild.members.fetch(message.author.id);
+  return Boolean(member.roles.resolve(GUEST_ROLE_ID));


This bit feels a little bit convoluted, what is the value of member.roles.resolve(GUEST_ROLE_ID)? Is it something or null and that's why we wrap it into Boolean to get an implicit conversion to false if null?

I'd go for something explicit like member.roles.resolve(GUEST_ROLE_ID) !== null.

infomiho · 2025-09-08T11:43:41Z

src/types/helpers.ts

+  -readonly [K in keyof T]: T[K];
+};
+
+export type DeepWritable<T> = {


If not used, maybe we can remove this util?

My reason is that it makes it easier to understand Writable is not recursive.
We can remove.

infomiho · 2025-09-08T11:46:53Z

src/discord/bot/analytics/common.ts

-  const options: Discord.MessageOptions = {};
+): Discord.MessageCreateOptions {
+  const options: Discord.MessageCreateOptions = {};
+  const embeds: Writable<Discord.MessageCreateOptions["embeds"]> = [];


This threw me off a bit since it's removing readonly for an array of something and I expected Writeable to work on objects only. But I guess this is the way to do it since you need their type that readonly.

Yeah, this one is hard to do.
Shame they didn't extract their "files" and "embeds" into separate types before making them readonly.

update

76ab3c5