Skip to content

test: enable persistent cache #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test: enable persistent cache #630

wants to merge 1 commit into from

Conversation

Timeless0911
Copy link
Contributor

Summary

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Dec 30, 2024 •
edited
Loading

✅ Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 6d8bbb2
🔍 Latest deploy log https://app.netlify.com/projects/rslib/deploys/686ceddd9747070008d44437
😎 Deploy Preview https://deploy-preview-630--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Timeless0911 Timeless0911 marked this pull request as ready for review December 30, 2024 09:09
@Timeless0911 Timeless0911 marked this pull request as draft December 30, 2024 09:10
@fi3ework fi3ework linked an issue Dec 31, 2024 that may be closed by this pull request
[Bug]: Missing exports when using Rslib with Rspack 1.2.0-alpha.0 #633
Closed
@Timeless0911
Copy link
Contributor Author

image

Timeless0911
Timeless0911 commented Jan 2, 2025
View reviewed changes
packages/core/src/config.ts Outdated
rspack: {
experiments: {
cache: {
version:
Copy link
Contributor Author

@Timeless0911 Timeless0911 Jan 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invalidate:

  • config.name
  • config hash

@Timeless0911 Timeless0911 force-pushed the test/persis branch 3 times, most recently from 744442a to 60f1ad8 Compare February 13, 2025 06:52
@Timeless0911
Copy link
Contributor Author

Run pnpm test:integration twice

  1. Vue case
    image
  2. External module warning case -- external function does not be executed since hitting cache
    image
  3. watch case
    image

@Timeless0911
Copy link
Contributor Author

Timeless0911 commented Jul 4, 2025 •
edited
Loading

image
seems not work fine with multi compiler for cache invalidate key

If different config with same id, it will fail too, see this case https://github.com/web-infra-dev/rslib/blob/test/persis/tests/integration/shims/esm/rslibShimsDisabled.config.ts

@Timeless0911 Timeless0911 force-pushed the test/persis branch 3 times, most recently from 2af0861 to 088dfa0 Compare July 7, 2025 09:35
@Timeless0911
Copy link
Contributor Author

Timeless0911 commented Jul 8, 2025 •
edited
Loading

There is only one case left now, which is related to the implementation of unplugin.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing exports when using Rslib with Rspack 1.2.0-alpha.0
1 participant
@Timeless0911