Load all categories instead of just the first page #24785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazytonyli
changed the title
The `raw` property becomes Optional in Automattic/wordpress-rs#863, to handle revision related endpoints. However, it's still returned in the /media?context=edit responses.
crazytonyli
force-pushed
the
bugfix/load-all-categories
branch
from
0e43b4b to
eb10e28
Compare
|
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 28703 | |
| Version | PR #24785 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | eb10e28 | |
| Installation URL | 3l3p1q9kcv60g |
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 28703 | |
| Version | PR #24785 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | eb10e28 | |
| Installation URL | 14dpaohu7iba0 |
kean
approved these changes
Sep 2, 2025
| @@ -144,7 +144,7 @@ private extension RemoteMedia { | |||
|
|
|||
| self.mediaID = NSNumber(value: media.id) | |||
| self.url = URL(string: media.sourceUrl) | |||
| self.guid = URL(string: media.guid.raw) | |||
| self.guid = media.guid.raw.flatMap(URL.init(string:)) | |||
There was a problem hiding this comment.
Nice. So I guess the compiler infers which initializer to use when seeing URL.init? I'll leave this code as it is for now, but I'll try this shorter syntax next time.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
getCategoriesWithSuccess:failure:function was implemented incorrectly. We are supposed to return all categories, but the implementation only returns the first page. This PR fixes that issue.