-
Notifications
You must be signed in to change notification settings - Fork 7.8k
ci: fix github actions for twister blackbox tests #95048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix github actions for twister blackbox tests #95048
Conversation
Twister blackbox tests are not executed on CI. This change fixes the problem. Signed-off-by: Lukasz Fundakowski <lukasz.fundakowski@nordicsemi.no>
0af20cd
to
4b34651
Compare
|
CI doesn't appear to be happy? |
uh oh you are right, guess it was masking a failure after all, @fundakol have you looked into it already by any chance? |
I reviewed the failed tests, but they are too complicated for me to fix. You might want to find the person who broke those tests and ask him to provide a fix. Alternatively, you can mark all those tests with |
I found one commit which breaks one test: You can bisect other tests with this solution (I assume you have installed all required packages) Install nox: pip install nox Create import os
from pathlib import Path
import nox
ROOT_DIR = Path.home().joinpath("zephyrproject")
@nox.session(python=False)
def west_update(session):
with session.chdir(ROOT_DIR):
session.run('west', 'update', silent=True)
@nox.session(python=False)
def test(session):
env = os.environ.copy()
env["PYTHONPATH"] = f'{ROOT_DIR / "zephyr/scripts"}:{ROOT_DIR / "zephyr/scripts/pylib"}:{ROOT_DIR / "zephyr/scripts/pylib/twister"}'
session.run(
'pytest', "scripts/tests/twister_blackbox/test_testplan.py",
'-k', "test_subtest[valid]",
env=env
) Start bisect: git bisect start
git bisect good d2ebe9c6de2ca96ca7370a82589ce6f2cd0c8385
git bisect bad b68058787e992ca199ff287336e349d1c1ba22b1
git bisect run nox |
merged in another PR |
Twister blackbox tests are not executed on CI.
This change fixes the problem.
It is broken since https://github.com/zephyrproject-rtos/zephyr/pull/88754/files