Add noreply setting to default docker compose file #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had to set this today because out of the box Zulip sends invites as noreply-<guid>@smtp.example.com instead of just noreply@smtp.example.com, which was causing email bounces as I didn't have a sending identity for that particular email address. The default is true for security reasons as listed in [this hack](https://medium.com/intigriti/how-i-hacked-hundreds-of-companies-through-their-helpdesk-b7680ddc2d4c), but I'd argue setting this setting to default to False will be the most pain-free way for most self-hosted users that are only running Zulip and not running it alongside an 'email to public support ticket tracker' feature. Having said that, even if it is preferred to leave this at True, it will still help smooth the way for self-hosted users to find and change this setting up front rather than needing to track this down and manually create the setting.
|
@Eevoo thanks for the report; I don't understand why the emails would have been sent as There is certainly an argument for going with the smooth approach rather than the most secure approach, but I want to make sure that there isn't a bug here as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to set this today because out of the box Zulip sends invites as noreply-@smtp.example.com instead of just noreply@smtp.example.com, which was causing email bounces as I didn't have a sending identity for that particular email address. The default is true for security reasons as listed in this hack, but I'd argue setting this setting to default to False will be the most pain-free way for most self-hosted users that are only running Zulip and not running it alongside an 'email to public support ticket tracker' feature.
Having said that, even if it is preferred to leave this at True, it will still help smooth the way for self-hosted users to find and change this setting up front rather than needing to track this down and manually create the setting.