Skip to content

ZULIP_GIT_REF only allows fully qualified git ref name #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ZULIP_GIT_REF only allows fully qualified git ref name #412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ you'd prefer to have the containers run in the background, you can use

If you want to build the Zulip image yourself, you can do that by
running `docker-compose build`; see also
[the documentation on building a custom Git version version](#upgrading-from-a-git-repository).
[the documentation on building a custom Git version version](/UPGRADING.md#upgrading-from-a-git-repository).

### Connecting to your Zulip server

Expand Down
7 changes: 4 additions & 3 deletions UPGRADING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,13 @@ docker-compose exec -u zulip zulip cat /home/zulip/deployments/current/version.p
args:
# Change these if you want to build zulip from a different repo/branch
ZULIP_GIT_URL: https://github.com/zulip/zulip.git
ZULIP_GIT_REF: master
ZULIP_GIT_REF: "refs/remotes/origin/master"
```

You can set `ZULIP_GIT_URL` to any clone of the zulip/zulip git repository,
and `ZULIP_GIT_REF` to be any ref name in that repository (e.g. `master` or
`1.9.0` or `445932cc8613c77ced023125248c8b966b3b7528`).
and `ZULIP_GIT_REF` to be any fully qualified git ref name in that repository
(e.g. `refs/remotes/origin/master` or `refs/remotes/origin/1.9.0`
or `refs/remotes/origin/445932cc8613c77ced023125248c8b966b3b7528`).

2. Run `docker-compose build zulip` to build a Zulip Docker image from the
specified Git version.
Expand Down