Skip to content

messages: Update metadata handling for message reaction. #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

messages: Update metadata handling for message reaction. #1555

wants to merge 1 commit into from

Conversation

mounilKshah
Copy link
Collaborator

What does this PR do, and why?

Reaction metadata has been changed in the messages API endpoint as per ZFL 2 in Zulip 3.0. The user_id is used to identify the reaction's user.

  • The tests are failing for reactions_view

Discussed in zulip-terminal > reaction metadata

External discussion & connections

  • Discussed in #zulip-terminal in reaction metadata
  • Fully fixes #
  • Partially fixes issue #
  • Builds upon previous unmerged work in PR #
  • Is a follow-up to work in PR #
  • Requires merge of PR #
  • Merge will enable work on #

How did you test this?

  • Manually - Behavioral changes
  • Manually - Visual changes
  • Adapting existing automated tests
  • Adding automated tests for new behavior (or missing tests)
  • Existing automated tests should already cover this (only a refactor of tested code)

Self-review checklist for each commit

  • It is a minimal coherent idea
  • It has a commit summary following the documented style (title & body)
  • It has a commit summary describing the motivation and reasoning for the change
  • It individually passes linting and tests
  • It contains test additions for any new behavior
  • It flows clearly from a previous branch commit, and/or prepares for the next commit

@zulipbot zulipbot added the size: M [Automatic label added by zulipbot] label Nov 17, 2024
@mounilKshah mounilKshah requested a review from neiljp November 17, 2024 11:50
@mounilKshah
messages: Update metadata handling for message reaction.
4a82d95 
This commit is in sync with the new metadata changes for
reactions data sent in messages API. It uses user_id
for identification of the reaction's user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neiljp neiljp Awaiting requested review from neiljp

Assignees
No one assigned
Labels
size: M [Automatic label added by zulipbot]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mounilKshah @zulipbot