-
Notifications
You must be signed in to change notification settings - Fork 39
[MOB-11957] ios-crashes-when-clicking-track-push-open-with-ca #695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 12 commits
32c7eb8
5d8c543
b6e4488
3e252ee
e0d026e
dfb4934
5a946b2
c009a1e
f9aa273
560a8c5
91062db
5b7870a
4cc665f
7664ace
18bd0af
26fa44b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -172,7 +172,7 @@ public void getUserId(Promise promise) { | |
promise.resolve(RNIterableInternal.getUserId()); | ||
} | ||
|
||
public void trackEvent(String name, ReadableMap dataFields) { | ||
public void trackEvent(String name, @Nullable ReadableMap dataFields) { | ||
IterableLogger.v(TAG, "trackEvent"); | ||
IterableApi.getInstance().track(name, optSerializedDataFields(dataFields)); | ||
} | ||
|
@@ -182,16 +182,16 @@ public void updateCart(ReadableArray items) { | |
IterableApi.getInstance().updateCart(Serialization.commerceItemsFromReadableArray(items)); | ||
} | ||
|
||
public void trackPurchase(double total, ReadableArray items, ReadableMap dataFields) { | ||
public void trackPurchase(double total, ReadableArray items, @Nullable ReadableMap dataFields) { | ||
IterableLogger.v(TAG, "trackPurchase"); | ||
IterableApi.getInstance().trackPurchase(total, Serialization.commerceItemsFromReadableArray(items), optSerializedDataFields(dataFields)); | ||
} | ||
|
||
public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) { | ||
public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? templateId.intValue() : null, messageId, optSerializedDataFields(dataFields)); | ||
} | ||
|
||
public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) { | ||
public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
IterableLogger.v(TAG, "updateSubscriptions"); | ||
Integer finalCampaignId = null, finalTemplateId = null; | ||
if (campaignId > 0) { | ||
|
@@ -270,7 +270,7 @@ public void getAttributionInfo(Promise promise) { | |
} | ||
} | ||
|
||
public void setAttributionInfo(ReadableMap attributionInfoReadableMap) { | ||
public void setAttributionInfo(@Nullable ReadableMap attributionInfoReadableMap) { | ||
IterableLogger.printInfo(); | ||
try { | ||
JSONObject attributionInfoJson = Serialization.convertMapToJson(attributionInfoReadableMap); | ||
|
@@ -598,7 +598,7 @@ public void removeListeners(double count) { | |
// Keep: Required for RN built in Event Emitter Calls. | ||
} | ||
|
||
public void passAlongAuthToken(String authToken) { | ||
public void passAlongAuthToken(@Nullable String authToken) { | ||
passedAuthToken = authToken; | ||
|
||
if (authHandlerCallbackLatch != null) { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -77,7 +77,7 @@ public void getUserId(Promise promise) { | |
} | ||
|
||
@Override | ||
public void trackEvent(String name, ReadableMap dataFields) { | ||
public void trackEvent(String name, @Nullable ReadableMap dataFields) { | ||
moduleImpl.trackEvent(name, dataFields); | ||
} | ||
|
||
|
@@ -87,17 +87,17 @@ public void updateCart(ReadableArray items) { | |
} | ||
|
||
@Override | ||
public void trackPurchase(double total, ReadableArray items, ReadableMap dataFields) { | ||
public void trackPurchase(double total, ReadableArray items, @Nullable ReadableMap dataFields) { | ||
moduleImpl.trackPurchase(total, items, dataFields); | ||
} | ||
|
||
@Override | ||
public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) { | ||
public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
moduleImpl.trackPushOpenWithCampaignId(campaignId, templateId, messageId, appAlreadyRunning, dataFields); | ||
} | ||
|
||
@Override | ||
public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) { | ||
public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
moduleImpl.updateSubscriptions(emailListIds, unsubscribedChannelIds, unsubscribedMessageTypeIds, subscribedMessageTypeIds, campaignId, templateId); | ||
} | ||
|
||
|
@@ -127,7 +127,7 @@ public void getAttributionInfo(Promise promise) { | |
} | ||
|
||
@Override | ||
public void setAttributionInfo(ReadableMap attributionInfoReadableMap) { | ||
public void setAttributionInfo(@Nullable ReadableMap attributionInfoReadableMap) { | ||
moduleImpl.setAttributionInfo(attributionInfoReadableMap); | ||
} | ||
|
||
|
@@ -191,7 +191,6 @@ public void setAutoDisplayPaused(final boolean paused) { | |
moduleImpl.setAutoDisplayPaused(paused); | ||
} | ||
|
||
@Override | ||
public void wakeApp() { | ||
moduleImpl.wakeApp(); | ||
} | ||
|
@@ -206,7 +205,6 @@ public void endSession() { | |
moduleImpl.endSession(); | ||
} | ||
|
||
@Override | ||
public void updateVisibleRows(ReadableArray visibleRows) { | ||
moduleImpl.updateVisibleRows(visibleRows); | ||
} | ||
|
@@ -221,8 +219,7 @@ public void removeListeners(double count) { | |
moduleImpl.removeListeners(count); | ||
} | ||
|
||
@Override | ||
public void passAlongAuthToken(String authToken) { | ||
public void passAlongAuthToken(@Nullable String authToken) { | ||
moduleImpl.passAlongAuthToken(authToken); | ||
} | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -77,7 +77,7 @@ public void getUserId(Promise promise) { | |
} | ||
|
||
@ReactMethod | ||
public void trackEvent(String name, ReadableMap dataFields) { | ||
public void trackEvent(String name, @Nullable ReadableMap dataFields) { | ||
moduleImpl.trackEvent(name, dataFields); | ||
} | ||
|
||
|
@@ -87,17 +87,17 @@ public void updateCart(ReadableArray items) { | |
} | ||
|
||
@ReactMethod | ||
public void trackPurchase(double total, ReadableArray items, ReadableMap dataFields) { | ||
public void trackPurchase(double total, ReadableArray items, @Nullable ReadableMap dataFields) { | ||
moduleImpl.trackPurchase(total, items, dataFields); | ||
} | ||
|
||
@ReactMethod | ||
public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) { | ||
public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
moduleImpl.trackPushOpenWithCampaignId(campaignId, templateId, messageId, appAlreadyRunning, dataFields); | ||
} | ||
|
||
@ReactMethod | ||
public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) { | ||
public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
moduleImpl.updateSubscriptions(emailListIds, unsubscribedChannelIds, unsubscribedMessageTypeIds, subscribedMessageTypeIds, campaignId, templateId); | ||
} | ||
|
||
|
@@ -127,7 +127,7 @@ public void getAttributionInfo(Promise promise) { | |
} | ||
|
||
@ReactMethod | ||
public void setAttributionInfo(ReadableMap attributionInfoReadableMap) { | ||
public void setAttributionInfo(@Nullable ReadableMap attributionInfoReadableMap) { | ||
moduleImpl.setAttributionInfo(attributionInfoReadableMap); | ||
} | ||
|
||
|
@@ -222,7 +222,7 @@ public void removeListeners(double count) { | |
} | ||
|
||
@ReactMethod | ||
public void passAlongAuthToken(String authToken) { | ||
public void passAlongAuthToken(@Nullable String authToken) { | ||
moduleImpl.passAlongAuthToken(authToken); | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]