[MOB-11957] ios-crashes-when-clicking-track-push-open-with-ca #695

lposen · 2025-08-27T21:30:41Z

🔹 JIRA Ticket(s) if any

MOB-11957

✏️ Description

This pull request addresses type inconsistencies between the automatically generated code from React Native's codegen system and our iOS and Android native implementations. These inconsistencies were causing compilation errors and runtime issues when using the New Architecture.

The methods in both iOS and Android have been updated with parameters matching the codegen output.

Testing

Build both iOS and Android with new architecture enabled and poke around. If you hit anything in which the types do not match, the app will crash.

Optional -- double checking that the types are correct

iOS

Open the example project in Xcode
Build the example app from Xcode
When the build is complete, you should NOT see type mismatch messages in the logs. See the image below for what should NOT be there:

Android

Unfortunately, there is not an easy way to do this in android (at least, not one that I've seen).

A manual way to compare would be:

in the example directory, run npx react-native codegen --platform android
open example/android/app/build/generated/source/codegen/java/com/facebook/fbreact/specs/NativeRNIterableAPISpec.java
open RNIterableAPIModuleImpl.java, android/src/newarch/java/com/iterable/reactnative/RNIterableAPIModule.java, android/src/oldarch/java/com/iterable/reactnative/RNIterableAPIModule.java
Make sure that the parameter types in our code match the parameter types in the generated code

…r better safety

…tch codegen

…cally created jsi file

github-actions · 2025-08-27T21:31:47Z

Lines	Statements	Branches	Functions
	37.98% (177/466)	13.04% (24/184)	32.9% (51/155)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

…ing in RNIterableAPI

… for consistency

…ine message retrieval

…gnId

qlty-cloud-legacy · 2025-08-28T00:13:09Z

10 new issues

Tool	Category	Rule	Count
qlty	Structure	Function with many parameters (count = 5): initialize2WithApiKey	9
qlty	Structure	Function with high complexity (count = 5): initialize2WithApiKey	1

_{This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.}

qlty-cloud-legacy · 2025-08-28T00:13:10Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

@@ -187,8 +187,8 @@ public void trackPurchase(double total, ReadableArray items, ReadableMap dataFie
        IterableApi.getInstance().trackPurchase(total, Serialization.commerceItemsFromReadableArray(items), optSerializedDataFields(dataFields));
    }

-    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
-        RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? templateId.intValue() : null, messageId, optSerializedDataFields(dataFields));
+    public void trackPushOpenWithCampaignId(double campaignId, double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T00:13:10Z

android/src/newarch/java/com/iterable/reactnative/RNIterableAPIModule.java

@@ -92,7 +92,7 @@ public void trackPurchase(double total, ReadableArray items, ReadableMap dataFie
  }

  @Override
-  public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+  public void trackPushOpenWithCampaignId(double campaignId, double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T00:13:10Z

android/src/oldarch/java/com/iterable/reactnative/RNIterableAPIModule.java

@@ -92,7 +92,7 @@ public void trackPurchase(double total, ReadableArray items, ReadableMap dataFie
    }

    @ReactMethod
-    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+    public void trackPushOpenWithCampaignId(double campaignId, double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

…enWithCampaignId

qlty-cloud-legacy · 2025-08-28T03:44:43Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

@@ -187,8 +187,8 @@ public void trackPurchase(double total, ReadableArray items, ReadableMap dataFie
        IterableApi.getInstance().trackPurchase(total, Serialization.commerceItemsFromReadableArray(items), optSerializedDataFields(dataFields));
    }

-    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
-        RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? templateId.intValue() : null, messageId, optSerializedDataFields(dataFields));
+    public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T03:44:43Z

android/src/newarch/java/com/iterable/reactnative/RNIterableAPIModule.java

@@ -92,7 +92,7 @@ public void trackPurchase(double total, ReadableArray items, ReadableMap dataFie
  }

  @Override
-  public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+  public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T03:44:43Z

android/src/oldarch/java/com/iterable/reactnative/RNIterableAPIModule.java

@@ -92,7 +92,7 @@ public void trackPurchase(double total, ReadableArray items, ReadableMap dataFie
    }

    @ReactMethod
-    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+    public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

Copilot

Pull Request Overview

This PR fixes iOS crashes that were occurring when clicking track push open with certain campaign parameters. The main issue was inconsistent parameter type handling between React Native bridge methods and Swift implementations.

Standardizes parameter types from NSNumber to Double in iOS bridge methods
Adds proper nullable annotations to prevent null pointer exceptions
Removes redundant code and fixes incomplete method calls

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
ios/RNIterableAPI/ReactIterableAPI.swift	Updates parameter types from NSNumber to Double with proper casting to NSNumber for API calls
ios/RNIterableAPI/RNIterableAPI.mm	Changes Objective-C bridge method signatures to use double instead of NSNumber parameters
android/src/oldarch/java/com/iterable/reactnative/RNIterableAPIModule.java	Adds @nullable annotations to prevent null pointer exceptions
android/src/newarch/java/com/iterable/reactnative/RNIterableAPIModule.java	Adds @nullable annotations and removes redundant @OverRide annotations
android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java	Updates null handling and type casting for template ID parameter

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-28T03:44:51Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

-    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
-        RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? templateId.intValue() : null, messageId, optSerializedDataFields(dataFields));
+    public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {
+        RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? (int) templateId : null, messageId, optSerializedDataFields(dataFields));


The casting (int) templateId could cause precision loss if templateId contains decimal values. Since templateId is a Double, it should use templateId.intValue() instead of direct casting to maintain consistency with the original code pattern.

Suggested change

RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? (int) templateId : null, messageId, optSerializedDataFields(dataFields));

RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? templateId.intValue() : null, messageId, optSerializedDataFields(dataFields));

…sistency

qlty-cloud-legacy · 2025-08-28T05:18:46Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

        IterableLogger.v(TAG, "trackPurchase");
        IterableApi.getInstance().trackPurchase(total, Serialization.commerceItemsFromReadableArray(items), optSerializedDataFields(dataFields));
    }

-    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+    public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T05:18:46Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

        RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? templateId.intValue() : null, messageId, optSerializedDataFields(dataFields));
    }

-    public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+    public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T05:18:46Z

android/src/newarch/java/com/iterable/reactnative/RNIterableAPIModule.java

    moduleImpl.trackPurchase(total, items, dataFields);
  }

  @Override
-  public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+  public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T05:18:46Z

android/src/newarch/java/com/iterable/reactnative/RNIterableAPIModule.java

    moduleImpl.trackPushOpenWithCampaignId(campaignId, templateId, messageId, appAlreadyRunning, dataFields);
  }

  @Override
-  public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+  public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T05:18:46Z

android/src/oldarch/java/com/iterable/reactnative/RNIterableAPIModule.java

      moduleImpl.trackPurchase(total, items, dataFields);
    }

    @ReactMethod
-    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+    public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T05:18:46Z

android/src/oldarch/java/com/iterable/reactnative/RNIterableAPIModule.java

      moduleImpl.trackPushOpenWithCampaignId(campaignId, templateId, messageId, appAlreadyRunning, dataFields);
    }

    @ReactMethod
-    public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+    public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

…en-clicking-track-push-open-with-ca

qlty-cloud-legacy · 2025-08-28T20:11:17Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

        IterableLogger.v(TAG, "trackPurchase");
        IterableApi.getInstance().trackPurchase(total, Serialization.commerceItemsFromReadableArray(items), optSerializedDataFields(dataFields));
    }

-    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+    public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:11:17Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

        RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? templateId.intValue() : null, messageId, optSerializedDataFields(dataFields));
    }

-    public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+    public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:11:18Z

android/src/newarch/java/com/iterable/reactnative/RNIterableAPIModule.java

    moduleImpl.trackPurchase(total, items, dataFields);
  }

  @Override
-  public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+  public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:11:18Z

android/src/newarch/java/com/iterable/reactnative/RNIterableAPIModule.java

    moduleImpl.trackPushOpenWithCampaignId(campaignId, templateId, messageId, appAlreadyRunning, dataFields);
  }

  @Override
-  public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+  public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:11:18Z

android/src/oldarch/java/com/iterable/reactnative/RNIterableAPIModule.java

      moduleImpl.trackPurchase(total, items, dataFields);
    }

    @ReactMethod
-    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+    public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:11:18Z

android/src/oldarch/java/com/iterable/reactnative/RNIterableAPIModule.java

      moduleImpl.trackPushOpenWithCampaignId(campaignId, templateId, messageId, appAlreadyRunning, dataFields);
    }

    @ReactMethod
-    public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+    public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

…-arch/MOB-11957-ios-crashes-when-clicking-track-push-open-with-ca

qlty-cloud-legacy · 2025-08-28T20:16:01Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

        IterableLogger.v(TAG, "trackPurchase");
        IterableApi.getInstance().trackPurchase(total, Serialization.commerceItemsFromReadableArray(items), optSerializedDataFields(dataFields));
    }

-    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+    public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:16:01Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

        RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? templateId.intValue() : null, messageId, optSerializedDataFields(dataFields));
    }

-    public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+    public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:16:01Z

android/src/newarch/java/com/iterable/reactnative/RNIterableAPIModule.java

    moduleImpl.trackPurchase(total, items, dataFields);
  }

  @Override
-  public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+  public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:16:01Z

android/src/newarch/java/com/iterable/reactnative/RNIterableAPIModule.java

    moduleImpl.trackPushOpenWithCampaignId(campaignId, templateId, messageId, appAlreadyRunning, dataFields);
  }

  @Override
-  public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+  public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:16:02Z

android/src/oldarch/java/com/iterable/reactnative/RNIterableAPIModule.java

      moduleImpl.trackPurchase(total, items, dataFields);
    }

    @ReactMethod
-    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+    public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:16:02Z

android/src/oldarch/java/com/iterable/reactnative/RNIterableAPIModule.java

      moduleImpl.trackPushOpenWithCampaignId(campaignId, templateId, messageId, appAlreadyRunning, dataFields);
    }

    @ReactMethod
-    public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+    public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:57:23Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

        IterableLogger.v(TAG, "trackPurchase");
        IterableApi.getInstance().trackPurchase(total, Serialization.commerceItemsFromReadableArray(items), optSerializedDataFields(dataFields));
    }

-    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+    public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:57:23Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

        RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? templateId.intValue() : null, messageId, optSerializedDataFields(dataFields));
    }

-    public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+    public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:57:23Z

android/src/newarch/java/com/iterable/reactnative/RNIterableAPIModule.java

    moduleImpl.trackPurchase(total, items, dataFields);
  }

  @Override
-  public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+  public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:57:23Z

android/src/newarch/java/com/iterable/reactnative/RNIterableAPIModule.java

    moduleImpl.trackPushOpenWithCampaignId(campaignId, templateId, messageId, appAlreadyRunning, dataFields);
  }

  @Override
-  public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+  public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:57:24Z

android/src/oldarch/java/com/iterable/reactnative/RNIterableAPIModule.java

      moduleImpl.trackPurchase(total, items, dataFields);
    }

    @ReactMethod
-    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+    public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-08-28T20:57:24Z

android/src/oldarch/java/com/iterable/reactnative/RNIterableAPIModule.java

      moduleImpl.trackPushOpenWithCampaignId(campaignId, templateId, messageId, appAlreadyRunning, dataFields);
    }

    @ReactMethod
-    public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+    public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

qlty-cloud-legacy · 2025-09-05T19:56:02Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

        IterableLogger.v(TAG, "trackPurchase");
        IterableApi.getInstance().trackPurchase(total, Serialization.commerceItemsFromReadableArray(items), optSerializedDataFields(dataFields));
    }

-    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+    public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-09-05T19:56:02Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

        RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? templateId.intValue() : null, messageId, optSerializedDataFields(dataFields));
    }

-    public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+    public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

qlty-cloud-legacy · 2025-09-05T19:56:02Z

android/src/newarch/java/com/iterable/reactnative/RNIterableAPIModule.java

    moduleImpl.trackPurchase(total, items, dataFields);
  }

  @Override
-  public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+  public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-09-05T19:56:03Z

android/src/newarch/java/com/iterable/reactnative/RNIterableAPIModule.java

    moduleImpl.trackPushOpenWithCampaignId(campaignId, templateId, messageId, appAlreadyRunning, dataFields);
  }

  @Override
-  public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+  public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

qlty-cloud-legacy · 2025-09-05T19:56:03Z

android/src/oldarch/java/com/iterable/reactnative/RNIterableAPIModule.java

      moduleImpl.trackPurchase(total, items, dataFields);
    }

    @ReactMethod
-    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+    public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-09-05T19:56:03Z

android/src/oldarch/java/com/iterable/reactnative/RNIterableAPIModule.java

      moduleImpl.trackPushOpenWithCampaignId(campaignId, templateId, messageId, appAlreadyRunning, dataFields);
    }

    @ReactMethod
-    public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+    public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

…en-clicking-track-push-open-with-ca

qlty-cloud-legacy · 2025-09-05T20:01:12Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

        IterableLogger.v(TAG, "trackPurchase");
        IterableApi.getInstance().trackPurchase(total, Serialization.commerceItemsFromReadableArray(items), optSerializedDataFields(dataFields));
    }

-    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+    public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-09-05T20:01:12Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

        RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? templateId.intValue() : null, messageId, optSerializedDataFields(dataFields));
    }

-    public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+    public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

qlty-cloud-legacy · 2025-09-05T20:01:12Z

android/src/newarch/java/com/RNIterableAPIModule.java

    moduleImpl.trackPurchase(total, items, dataFields);
  }

  @Override
-  public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+  public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-09-05T20:01:12Z

android/src/newarch/java/com/RNIterableAPIModule.java

    moduleImpl.trackPushOpenWithCampaignId(campaignId, templateId, messageId, appAlreadyRunning, dataFields);
  }

  @Override
-  public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+  public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

qlty-cloud-legacy · 2025-09-05T20:01:13Z

android/src/oldarch/java/com/RNIterableAPIModule.java

      moduleImpl.trackPurchase(total, items, dataFields);
    }

    @ReactMethod
-    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+    public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-09-05T20:01:13Z

android/src/oldarch/java/com/RNIterableAPIModule.java

      moduleImpl.trackPushOpenWithCampaignId(campaignId, templateId, messageId, appAlreadyRunning, dataFields);
    }

    @ReactMethod
-    public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+    public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

…in the same order

qlty-cloud-legacy · 2025-09-05T20:13:44Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

        IterableLogger.v(TAG, "trackPurchase");
        IterableApi.getInstance().trackPurchase(total, Serialization.commerceItemsFromReadableArray(items), optSerializedDataFields(dataFields));
    }

-    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+    public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-09-05T20:13:45Z

android/src/main/java/com/iterable/reactnative/RNIterableAPIModuleImpl.java

        RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? templateId.intValue() : null, messageId, optSerializedDataFields(dataFields));
    }

-    public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+    public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

qlty-cloud-legacy · 2025-09-05T20:13:45Z

android/src/newarch/java/com/RNIterableAPIModule.java

@@ -32,8 +32,8 @@ public void initializeWithApiKey(String apiKey, ReadableMap configReadableMap, S
  }

  @Override
-  public void initialize2WithApiKey(String apiKey, ReadableMap configReadableMap, String apiEndPointOverride, String version, Promise promise) {
-    moduleImpl.initialize2WithApiKey(apiKey, configReadableMap, apiEndPointOverride, version, promise);
+  public void initialize2WithApiKey(String apiKey, ReadableMap configReadableMap, String version, String apiEndPointOverride, Promise promise) {


Function with many parameters (count = 5): initialize2WithApiKey [qlty:function-parameters]

qlty-cloud-legacy · 2025-09-05T20:13:45Z

android/src/newarch/java/com/RNIterableAPIModule.java

    moduleImpl.trackPurchase(total, items, dataFields);
  }

  @Override
-  public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+  public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-09-05T20:13:45Z

android/src/newarch/java/com/RNIterableAPIModule.java

    moduleImpl.trackPushOpenWithCampaignId(campaignId, templateId, messageId, appAlreadyRunning, dataFields);
  }

  @Override
-  public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+  public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

qlty-cloud-legacy · 2025-09-05T20:13:45Z

android/src/oldarch/java/com/RNIterableAPIModule.java

@@ -34,8 +34,8 @@ public void initializeWithApiKey(String apiKey, ReadableMap configReadableMap, S
    }

    @ReactMethod
-    public void initialize2WithApiKey(String apiKey, ReadableMap configReadableMap, String apiEndPointOverride, String version, Promise promise) {
-      moduleImpl.initialize2WithApiKey(apiKey, configReadableMap, apiEndPointOverride, version, promise);
+    public void initialize2WithApiKey(String apiKey, ReadableMap configReadableMap, String version, String apiEndPointOverride, Promise promise) {


Function with many parameters (count = 5): initialize2WithApiKey [qlty:function-parameters]

qlty-cloud-legacy · 2025-09-05T20:13:45Z

android/src/oldarch/java/com/RNIterableAPIModule.java

      moduleImpl.trackPurchase(total, items, dataFields);
    }

    @ReactMethod
-    public void trackPushOpenWithCampaignId(double campaignId, Double templateId, String messageId, boolean appAlreadyRunning, ReadableMap dataFields) {
+    public void trackPushOpenWithCampaignId(double campaignId, @Nullable Double templateId, String messageId, boolean appAlreadyRunning, @Nullable ReadableMap dataFields) {


Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]

qlty-cloud-legacy · 2025-09-05T20:13:45Z

android/src/oldarch/java/com/RNIterableAPIModule.java

      moduleImpl.trackPushOpenWithCampaignId(campaignId, templateId, messageId, appAlreadyRunning, dataFields);
    }

    @ReactMethod
-    public void updateSubscriptions(ReadableArray emailListIds, ReadableArray unsubscribedChannelIds, ReadableArray unsubscribedMessageTypeIds, ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {
+    public void updateSubscriptions(@Nullable ReadableArray emailListIds, @Nullable ReadableArray unsubscribedChannelIds, @Nullable ReadableArray unsubscribedMessageTypeIds, @Nullable ReadableArray subscribedMessageTypeIds, double campaignId, double templateId) {


Function with many parameters (count = 6): updateSubscriptions [qlty:function-parameters]

evantk91

Left some comments.

evantk91 · 2025-09-05T22:36:19Z

ios/RNIterableAPI/RNIterableAPI.mm

  [_swiftAPI passAlongAuthToken:authToken];
 }

+- (void)wakeApp {
+  // Placeholder function -- this method is only used in Android


evantk91 · 2025-09-05T22:39:39Z

ios/RNIterableAPI/RNIterableAPI.mm

@@ -106,7 +106,7 @@ - (void)getUserId:(RCTPromiseResolveBlock)resolve
  [_swiftAPI getUserId:resolve rejecter:reject];
 }

- (void)setInAppShowResponse:(NSNumber *)inAppShowResponse {
+- (void)setInAppShowResponse:(double)inAppShowResponse {


Where are you aligning the NSNumbers with doubles?

evantk91 · 2025-09-05T22:41:02Z

ios/RNIterableAPI/RNIterableAPI.mm

-        campaignId templateId : (NSNumber *)templateId messageId : (NSString *)
-            messageId appAlreadyRunning : (BOOL)
-                appAlreadyRunning dataFields : (NSDictionary *)dataFields) {
+    trackPushOpenWithCampaignId : (double)campaignId templateId : (NSNumber *)


Yeah should template be an double instead of NSNumber?

lposen added 3 commits August 21, 2025 19:19

refactor: update ios interfaces to enforce non-nullable parameters fo…

32c7eb8

…r better safety

refactor: update parameter types in RNIterableAPI to use Double to ma…

5d8c543

…tch codegen

refactor: update parameter types in RNIterableAPI to reflect automati…

b6e4488

…cally created jsi file

lposen requested a review from Copilot August 27, 2025 21:31

This comment was marked as outdated.

Sign in to view

lposen and others added 2 commits August 27, 2025 15:11

Update ios/RNIterableAPI/ReactIterableAPI.swift

3e252ee

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

refactor: simplify attribution info handling and improve error report…

e0d026e

…ing in RNIterableAPI

lposen requested a review from Copilot August 27, 2025 22:20

This comment was marked as outdated.

Sign in to view

lposen added 2 commits August 27, 2025 15:46

refactor: update templateId parameter type to Double in RNIterableAPI…

dfb4934

… for consistency

refactor: remove redundant error handling in RNIterableAPI to streaml…

5a946b2

…ine message retrieval

lposen requested a review from Copilot August 27, 2025 23:40

This comment was marked as outdated.

Sign in to view

refactor: update templateId type to double in trackPushOpenWithCampai…

c009a1e

…gnId

qlty-cloud-legacy bot reviewed Aug 28, 2025

View reviewed changes

refactor: update templateId parameter type to nullable in trackPushOp…

f9aa273

…enWithCampaignId

lposen requested a review from Copilot August 28, 2025 03:44

qlty-cloud-legacy bot reviewed Aug 28, 2025

View reviewed changes

Copilot AI reviewed Aug 28, 2025

View reviewed changes

refactor: update parameter types to nullable in RNIterableAPI for con…

560a8c5

…sistency

qlty-cloud-legacy bot reviewed Aug 28, 2025

View reviewed changes

Merge branch 'new-arch/master' into new-arch/MOB-11957-ios-crashes-wh…

91062db

…en-clicking-track-push-open-with-ca

qlty-cloud-legacy bot reviewed Aug 28, 2025

View reviewed changes

Merge branch 'new-arch/MOB-11955-configure-new-architecture' into new…

5b7870a

…-arch/MOB-11957-ios-crashes-when-clicking-track-push-open-with-ca

qlty-cloud-legacy bot reviewed Aug 28, 2025

View reviewed changes

refactor: add wakeApp placeholder method

4cc665f

qlty-cloud-legacy bot reviewed Aug 28, 2025

View reviewed changes

Base automatically changed from new-arch/MOB-11955-configure-new-architecture to new-arch/master September 5, 2025 19:54

qlty-cloud-legacy bot reviewed Sep 5, 2025

View reviewed changes

Merge branch 'new-arch/master' into new-arch/MOB-11957-ios-crashes-wh…

7664ace

…en-clicking-track-push-open-with-ca

qlty-cloud-legacy bot reviewed Sep 5, 2025

View reviewed changes

refactor: update initialize2WithApiKey so that parameters are always …

18bd0af

…in the same order

qlty-cloud-legacy bot reviewed Sep 5, 2025

View reviewed changes

evantk91 reviewed Sep 5, 2025

View reviewed changes

	RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? (int) templateId : null, messageId, optSerializedDataFields(dataFields));
	RNIterableInternal.trackPushOpenWithCampaignId((int) campaignId, templateId != null ? templateId.intValue() : null, messageId, optSerializedDataFields(dataFields));

[MOB-11957] ios-crashes-when-clicking-track-push-open-with-ca #695

Are you sure you want to change the base?

[MOB-11957] ios-crashes-when-clicking-track-push-open-with-ca #695

Conversation

lposen commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔹 JIRA Ticket(s) if any

✏️ Description

Testing

Optional -- double checking that the types are correct

iOS

Android

Uh oh!

github-actions bot commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

qlty-cloud-legacy bot commented Aug 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

10 new issues

Uh oh!

qlty-cloud-legacy bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

qlty-cloud-legacy bot Aug 28, 2025

lposen commented Aug 27, 2025 •

edited

Loading

github-actions bot commented Aug 27, 2025 •

edited

Loading

qlty-cloud-legacy bot commented Aug 28, 2025 •

edited

Loading