[MOB-11957] ios-crashes-when-clicking-track-push-open-with-ca #695
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -106,7 +106,7 @@ - (void)getUserId:(RCTPromiseResolveBlock)resolve | |||||
| [_swiftAPI getUserId:resolve rejecter:reject]; | ||||||
| } | ||||||
|
|
||||||
| - (void)setInAppShowResponse:(double)inAppShowResponse { | ||||||
evantk91 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| [_swiftAPI setInAppShowResponse:inAppShowResponse]; | ||||||
| } | ||||||
|
|
||||||
|
|
@@ -137,8 +137,8 @@ - (void)showMessage:(NSString *)messageId | |||||
| } | ||||||
|
|
||||||
| - (void)removeMessage:(NSString *)messageId | ||||||
| location:(double)location | ||||||
| source:(double)source { | ||||||
| [_swiftAPI removeMessage:messageId location:location source:source]; | ||||||
| } | ||||||
|
|
||||||
|
|
@@ -154,8 +154,8 @@ - (void)trackEvent:(NSString *)name dataFields:(NSDictionary *)dataFields { | |||||
| [_swiftAPI trackEvent:name dataFields:dataFields]; | ||||||
| } | ||||||
|
|
||||||
| - (void)trackPushOpenWithCampaignId:(double)campaignId | ||||||
| templateId:(double)templateId | ||||||
| messageId:(NSString *)messageId | ||||||
| appAlreadyRunning:(BOOL)appAlreadyRunning | ||||||
| dataFields:(NSDictionary *)dataFields { | ||||||
|
|
@@ -166,19 +166,19 @@ - (void)trackPushOpenWithCampaignId:(NSNumber *)campaignId | |||||
| dataFields:dataFields]; | ||||||
| } | ||||||
|
|
||||||
| - (void)trackInAppOpen:(NSString *)messageId location:(double)location { | ||||||
| [_swiftAPI trackInAppOpen:messageId location:location]; | ||||||
| } | ||||||
|
|
||||||
| - (void)trackInAppClick:(NSString *)messageId | ||||||
| location:(double)location | ||||||
| clickedUrl:(NSString *)clickedUrl { | ||||||
| [_swiftAPI trackInAppClick:messageId location:location clickedUrl:clickedUrl]; | ||||||
| } | ||||||
|
|
||||||
| - (void)trackInAppClose:(NSString *)messageId | ||||||
| location:(double)location | ||||||
| source:(double)source | ||||||
| clickedUrl:(NSString *)clickedUrl { | ||||||
| [_swiftAPI trackInAppClose:messageId | ||||||
| location:location | ||||||
|
|
@@ -187,16 +187,16 @@ - (void)trackInAppClose:(NSString *)messageId | |||||
| } | ||||||
|
|
||||||
| - (void)inAppConsume:(NSString *)messageId | ||||||
| location:(double)location | ||||||
| source:(double)source { | ||||||
| [_swiftAPI inAppConsume:messageId location:location source:source]; | ||||||
| } | ||||||
|
|
||||||
| - (void)updateCart:(NSArray *)items { | ||||||
| [_swiftAPI updateCart:items]; | ||||||
| } | ||||||
|
|
||||||
| - (void)trackPurchase:(double)total | ||||||
| items:(NSArray *)items | ||||||
| dataFields:(NSDictionary *)dataFields { | ||||||
| [_swiftAPI trackPurchase:total items:items dataFields:dataFields]; | ||||||
|
|
@@ -216,7 +216,7 @@ - (void)getAttributionInfo:(RCTPromiseResolveBlock)resolve | |||||
| [_swiftAPI getAttributionInfo:resolve rejecter:reject]; | ||||||
| } | ||||||
|
|
||||||
| - (void)setAttributionInfo:(NSDictionary *_Nullable)attributionInfo { | ||||||
| [_swiftAPI setAttributionInfo:attributionInfo]; | ||||||
| } | ||||||
|
|
||||||
|
|
@@ -243,12 +243,12 @@ - (void)handleAppLink:(NSString *)appLink | |||||
| [_swiftAPI handleAppLink:appLink resolver:resolve rejecter:reject]; | ||||||
| } | ||||||
|
|
||||||
| - (void)updateSubscriptions:(NSArray *_Nullable)emailListIds | ||||||
| unsubscribedChannelIds:(NSArray *_Nullable)unsubscribedChannelIds | ||||||
| unsubscribedMessageTypeIds:(NSArray *_Nullable)unsubscribedMessageTypeIds | ||||||
| subscribedMessageTypeIds:(NSArray *_Nullable)subscribedMessageTypeIds | ||||||
| campaignId:(double)campaignId | ||||||
| templateId:(double)templateId { | ||||||
| [_swiftAPI updateSubscriptions:emailListIds | ||||||
| unsubscribedChannelIds:unsubscribedChannelIds | ||||||
| unsubscribedMessageTypeIds:unsubscribedMessageTypeIds | ||||||
|
|
@@ -269,7 +269,7 @@ - (void)updateVisibleRows:(NSArray *)visibleRows { | |||||
| [_swiftAPI updateVisibleRows:visibleRows]; | ||||||
| } | ||||||
|
|
||||||
| - (void)passAlongAuthToken:(NSString *_Nullable)authToken { | ||||||
| [_swiftAPI passAlongAuthToken:authToken]; | ||||||
| } | ||||||
|
|
||||||
|
|
@@ -335,7 +335,7 @@ - (void)passAlongAuthToken:(NSString *)authToken { | |||||
| [_swiftAPI getUserId:resolve rejecter:reject]; | ||||||
| } | ||||||
|
|
||||||
| RCT_EXPORT_METHOD(setInAppShowResponse : (double)inAppShowResponse) { | ||||||
| [_swiftAPI setInAppShowResponse:inAppShowResponse]; | ||||||
| } | ||||||
|
|
||||||
|
|
@@ -363,8 +363,8 @@ - (void)passAlongAuthToken:(NSString *)authToken { | |||||
| rejecter:reject]; | ||||||
| } | ||||||
|
|
||||||
| RCT_EXPORT_METHOD(removeMessage : (NSString *)messageId location : (double) | ||||||
| location source : (double)source) { | ||||||
| [_swiftAPI removeMessage:messageId location:location source:source]; | ||||||
| } | ||||||
|
|
||||||
|
|
@@ -382,46 +382,45 @@ - (void)passAlongAuthToken:(NSString *)authToken { | |||||
| } | ||||||
|
|
||||||
| RCT_EXPORT_METHOD( | ||||||
| trackPushOpenWithCampaignId : (double)campaignId templateId : (double) | ||||||
| templateId messageId : (double)messageId appAlreadyRunning : (BOOL) | ||||||
|
There was a problem hiding this comment. The messageId parameter is incorrectly declared as double but should be NSString* since it's a string identifier, not a numeric value.
Suggested change
Copilot uses AI. Check for mistakes. |
||||||
| appAlreadyRunning dataFields : (NSDictionary *)dataFields) { | ||||||
| [_swiftAPI trackPushOpenWithCampaignId:campaignId | ||||||
| templateId:templateId | ||||||
| messageId:messageId | ||||||
| appAlreadyRunning:appAlreadyRunning | ||||||
| dataFields:dataFields]; | ||||||
| } | ||||||
|
|
||||||
| RCT_EXPORT_METHOD(trackInAppOpen : (NSString *)messageId location : (double) | ||||||
| location) { | ||||||
| [_swiftAPI trackInAppOpen:messageId location:location]; | ||||||
| } | ||||||
|
|
||||||
| RCT_EXPORT_METHOD(trackInAppClick : (NSString *)messageId location : (double) | ||||||
| location clickedUrl : (NSString *)clickedUrl) { | ||||||
| [_swiftAPI trackInAppClick:messageId location:location clickedUrl:clickedUrl]; | ||||||
| } | ||||||
|
|
||||||
| RCT_EXPORT_METHOD(trackInAppClose : (NSString *)messageId location : (double) | ||||||
| location source : (double)source clickedUrl : (NSString *) | ||||||
| clickedUrl) { | ||||||
evantk91 marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| [_swiftAPI trackInAppClose:messageId | ||||||
| location:location | ||||||
| source:source | ||||||
| clickedUrl:clickedUrl]; | ||||||
| } | ||||||
|
|
||||||
| RCT_EXPORT_METHOD(inAppConsume : (NSString *)messageId location : (double) | ||||||
| location source : (double)source) { | ||||||
| [_swiftAPI inAppConsume:messageId location:location source:source]; | ||||||
| } | ||||||
|
|
||||||
| RCT_EXPORT_METHOD(updateCart : (NSArray *)items) { | ||||||
| [_swiftAPI updateCart:items]; | ||||||
| } | ||||||
|
|
||||||
| RCT_EXPORT_METHOD(trackPurchase : (double)total items : (NSArray *) | ||||||
| items dataFields : (NSDictionary *)dataFields) { | ||||||
| [_swiftAPI trackPurchase:total items:items dataFields:dataFields]; | ||||||
| } | ||||||
|
|
@@ -430,6 +429,7 @@ - (void)passAlongAuthToken:(NSString *)authToken { | |||||
| BOOL)mergeNestedObjects) { | ||||||
| [_swiftAPI updateUser:dataFields mergeNestedObjects:mergeNestedObjects]; | ||||||
| } | ||||||
|
|
||||||
| RCT_EXPORT_METHOD(updateEmail : (NSString *)email authToken : (NSString *) | ||||||
| authToken) { | ||||||
| [_swiftAPI updateEmail:email authToken:authToken]; | ||||||
|
|
@@ -471,8 +471,8 @@ - (void)passAlongAuthToken:(NSString *)authToken { | |||||
| NSArray *) | ||||||
| unsubscribedChannelIds unsubscribedMessageTypeIds : (NSArray *) | ||||||
| unsubscribedMessageTypeIds subscribedMessageTypeIds : (NSArray *) | ||||||
| subscribedMessageTypeIds campaignId : (double) | ||||||
| campaignId templateId : (double)templateId) { | ||||||
| [_swiftAPI updateSubscriptions:emailListIds | ||||||
| unsubscribedChannelIds:unsubscribedChannelIds | ||||||
| unsubscribedMessageTypeIds:unsubscribedMessageTypeIds | ||||||
|
|
@@ -491,7 +491,7 @@ - (void)passAlongAuthToken:(NSString *)authToken { | |||||
| [_swiftAPI updateVisibleRows:visibleRows]; | ||||||
| } | ||||||
|
|
||||||
| RCT_EXPORT_METHOD(passAlongAuthToken : (NSString *_Nullable)authToken) { | ||||||
| [_swiftAPI passAlongAuthToken:authToken]; | ||||||
| } | ||||||
|
|
||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function with many parameters (count = 5): trackPushOpenWithCampaignId [qlty:function-parameters]